txn: fix pessimitic exist check(#19004) #19019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfzjywxk
added
type/bugfix
|
/run-all-tests |
jackysp
reviewed
Aug 5, 2020
store/tikv/txn.go
Outdated
| @@ -360,10 +362,26 @@ func (txn *tikvTxn) LockKeys(ctx context.Context, lockCtx *kv.LockCtx, keysInput | |||
| } | |||
| }() | |||
| txn.mu.Lock() | |||
| logutil.Logger(ctx).Info("[for debug] key len", zap.Int("len", len(keysInput))) | |||
There was a problem hiding this comment.
should we remove this debug log?
|
/run-all-tests |
|
/run-unit-test |
ti-srebot
added
status/LGT2
|
LGTM |
ti-srebot
added
status/LGT3
ti-srebot
approved these changes
Aug 6, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Cherry-pick #19004 to release 4.0 to close #18958
What is changed and how it works?
What's Changed:
txn.SetOptioninterface and the exist map will be used inunionStore.Get. It's different from the master branch behaviour.How it Works:
Related changes
Check List
Tests
Side effects
Release note