Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix incorrect result for != all (subq) #19576

Merged
merged 6 commits into from
Sep 7, 2020
Merged

planner: fix incorrect result for != all (subq) #19576

merged 6 commits into from
Sep 7, 2020

Conversation

eurekaka
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #19423

Problem Summary:

Incorrect result returned a kind of anti-semi-join.

What is changed and how it works?

What's Changed:

One kind of cases are fixed by #19472, but another kind of anti-semi-joins built from != all (subq) still have problems.

How it Works:

Make a copy of Column before modifying InOperand.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

N/A

Release note

  • Fix incorrect query result for != all (subq).

@eurekaka eurekaka added type/bugfix This PR fixes a bug. sig/planner SIG: Planner needs-cherry-pick-4.0 labels Aug 28, 2020
@eurekaka eurekaka requested review from winoros and XuHuaiyu August 28, 2020 08:37
@eurekaka eurekaka requested review from a team as code owners August 28, 2020 08:37
@eurekaka eurekaka removed request for a team August 28, 2020 08:38
@github-actions github-actions bot added the sig/execution SIG execution label Aug 28, 2020
winoros
winoros reviewed Aug 28, 2020
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 28, 2020
@eurekaka eurekaka requested a review from qw4990 September 1, 2020 11:19
qw4990
qw4990 approved these changes Sep 7, 2020
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Sep 7, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Sep 7, 2020
@qw4990 qw4990 added the status/can-merge Indicates a PR has been approved by a committer. label Sep 7, 2020
@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 19723

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@eurekaka merge failed.

@zz-jason
Copy link
Member

zz-jason commented Sep 7, 2020

/merge

@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 19704
  • 19630
  • 19592

@pingcap pingcap deleted a comment from ti-srebot Sep 7, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@eurekaka merge failed.

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 397e31a into pingcap:master Sep 7, 2020
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 7, 2020
@eurekaka @ti-srebot
cherry pick pingcap#19576 to release-4.0
68507c2 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Sep 7, 2020
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #19831

@eurekaka eurekaka deleted the anti-join branch September 7, 2020 06:24
eurekaka added a commit that referenced this pull request Sep 9, 2020
@ti-srebot @eurekaka
cherry pick #19576 to release-4.0 (#19831)
f9bc29b 
Signed-off-by: ti-srebot <[email protected]>

Co-authored-by: Kenan Yao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

@qw4990 qw4990 qw4990 approved these changes

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees
No one assigned
Labels
sig/execution SIG execution sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect result of an anti-semi-join query
5 participants
@eurekaka @ti-srebot @zz-jason @qw4990 @winoros