ddl: support column type change between decimal && SQL mode warnings #20012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AilinKid
requested review from
SunRunAway,
zimulala and
crazycs520
and removed request for
a team and
SunRunAway
github-actions
bot
added
sig/sql-infra
zimulala
reviewed
Sep 21, 2020
AilinKid
force-pushed
the
numeric_type_change
branch
from
b857538 to
596b35e
Compare
zimulala
reviewed
Sep 24, 2020
crazycs520
reviewed
Sep 25, 2020
Comment on lines
+4632
to
+4641
| Warnings: make(map[errors.ErrorID]*terror.Error), | ||
| WarningsCount: make(map[errors.ErrorID]int64), |
There was a problem hiding this comment.
How about merge those 2 maps into 1 map?
There was a problem hiding this comment.
good idea, how about refine this point in the next PR? (it needs an update in the parser and covers many code)
crazycs520
reviewed
Sep 25, 2020
crazycs520
reviewed
Sep 25, 2020
crazycs520
reviewed
Sep 25, 2020
zimulala
reviewed
Sep 26, 2020
| job.SetWarnings(mergeWarningsAndWarningsCount(partWarnings, job.ReorgMeta.Warnings, partWarningsCount, job.ReorgMeta.WarningsCount)) | ||
| w.reorgCtx.mu.Unlock() | ||
|
|
||
| w.reorgCtx.resetWarnings() |
There was a problem hiding this comment.
Why we need to reset warnings here？
There was a problem hiding this comment.
It's a partial result. After it was merged into the job, the next round DDL will collect new ones.
Signed-off-by: AilinKid <[email protected]>
Signed-off-by: AilinKid <[email protected]>
Signed-off-by: AilinKid <[email protected]>
|
/run-all-tests |
Signed-off-by: AilinKid <[email protected]>
|
/run-all-tests |
bb7133
reviewed
Sep 27, 2020
Signed-off-by: AilinKid <[email protected]>
crazycs520
reviewed
Sep 28, 2020
Co-authored-by: crazycs <[email protected]>
|
/run-all-tests |
ti-srebot
approved these changes
Sep 29, 2020
crazycs520
approved these changes
Sep 29, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
@AilinKid merge failed. |
|
/build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: AilinKid [email protected]
What problem does this PR solve?
Issue Number: close #19121
Since #19059 has supported the column type change between integers.
Linked Parser PR pingcap/parser#1031
This PR is to support the column type change between decimal, for example, changing
decimal(5,2)todecimal(3,1).This PR also tries to supply a kind of way to support the normal DDL warnings and strict DDL warnings which will be identified as warnings under non-strict SQL mode, otherwise, will be identified as errors.
What is changed and how it works?
What's Changed:
1: We have added the SQL Mode and warnings field in the parser. For why we don't put this into the job args directly, because the job args sometime will be cleaned at the end of
finishDDLJob, and be substituted with delete range ids.2: This PR only handled the SQL Mode and limited warning for column type change of decimal. There will be PRs later to complement the next works. For example, pass the SQL mode parameter to all DDL jobs and handle its warnings.
3: This PR only handled the column type between decimal, for more numeric types, such as float and double, more PRs is necessary.
Check List
Tests
Release note