Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: check constraint when alter enum/set type column (#19806) #20045

Merged
merged 9 commits into from
Sep 17, 2020
Merged

ddl: check constraint when alter enum/set type column (#19806) #20045

merged 9 commits into from
Sep 17, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #19806 to release-3.0

What problem does this PR solve?

Issue Number: close #19804

Problem Summary:

What is changed and how it works?

  • check constraint for enum/set column type
  • check type compatible for set type

set type follow enum type behiver, do not allow change position of elements

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

  • fix an issue that alter enum/set type does not check constraint

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Sep 17, 2020
Merged
@ti-srebot ti-srebot added component/expression contribution This PR is from a community contributor. sig/sql-infra SIG: SQL Infra type/3.0-cherry-pick labels Sep 17, 2020
@ti-srebot ti-srebot added this to the 3.0.19 milestone Sep 17, 2020
zimulala
zimulala reviewed Sep 17, 2020
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 17, 2020
wjhuang2016
wjhuang2016 reviewed Sep 17, 2020
View reviewed changes
Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 17, 2020
AilinKid
AilinKid approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Sep 17, 2020
@wjhuang2016 wjhuang2016 added the status/can-merge Indicates a PR has been approved by a committer. label Sep 17, 2020
@ti-srebot
Copy link
Contributor Author

Sorry @wjhuang2016, you don't have permission to trigger auto merge event on this branch.

@coocood
Copy link
Member

coocood commented Sep 17, 2020

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 19681

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@bb7133
Copy link
Member

bb7133 commented Sep 17, 2020

/run-all-tests

@bb7133 bb7133 merged commit 86c6d16 into pingcap:release-3.0 Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjhuang2016 wjhuang2016 wjhuang2016 left review comments

@zimulala zimulala zimulala left review comments

@AilinKid AilinKid AilinKid approved these changes

Assignees

@wjhuang2016 wjhuang2016

Labels
component/expression contribution This PR is from a community contributor. sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT3 The PR has already had 3 LGTM. type/3.0-cherry-pick
Projects
None yet
Milestone
v3.0.19
Development

Successfully merging this pull request may close these issues.
7 participants
@ti-srebot @coocood @bb7133 @zimulala @AilinKid @wjhuang2016 @xiongjiwei