planner: fix wrong behavior for != any() #20058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eurekaka
reviewed
Sep 17, 2020
planner/core/expression_rewriter.go
Outdated
| @@ -650,15 +652,15 @@ func (er *expressionRewriter) handleNEAny(lexpr, rexpr expression.Expression, np | |||
| return | |||
| } | |||
| plan4Agg := LogicalAggregation{ | |||
| AggFuncs: []*aggregation.AggFuncDesc{firstRowFunc, countFunc}, | |||
| AggFuncs: []*aggregation.AggFuncDesc{maxFunc, countFunc}, | |||
| }.Init(er.sctx, er.b.getSelectOffset()) | |||
| if hint := er.b.TableHints(); hint != nil { | |||
| plan4Agg.aggHints = hint.aggHints | |||
| } | |||
| plan4Agg.SetChildren(np) | |||
| firstRowResultCol := &expression.Column{ | |||
There was a problem hiding this comment.
Change this variable name as well?
| firstRowFunc, err := aggregation.NewAggFuncDesc(er.sctx, ast.AggFuncFirstRow, []expression.Expression{rexpr}, false) | ||
| // If there is NULL in s.id column, s.id should be the value that isn't null in condition t.id != s.id. | ||
| // So use function max to filter NULL. | ||
| maxFunc, err := aggregation.NewAggFuncDesc(er.sctx, ast.AggFuncMax, []expression.Expression{rexpr}, false) |
There was a problem hiding this comment.
Max would produce null result when the s.id is empty, would this impact the correctness of the result?
There was a problem hiding this comment.
I think firstrow also produces null result when the s.id is empty..
ti-srebot
approved these changes
Sep 17, 2020
eurekaka
added
the
status/can-merge
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Sep 17, 2020
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-3.0 in PR #20061 |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Sep 17, 2020
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-4.0 in PR #20062 |
SunRunAway
pushed a commit
that referenced
this pull request
Sep 21, 2020
bb7133
pushed a commit
that referenced
this pull request
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #20007
Problem Summary:
The result is unstable.
What is changed and how it works?
Proposal: xxx
What's Changed: Use max function instead of first_row function.
How it Works:
Related changes
Check List
Tests
Side effects
Release note