-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: fix show global variables return session variables also (#19341) #21045
executor: fix show global variables return session variables also (#19341) #21045
Conversation
Signed-off-by: ti-srebot <[email protected]>
Please follow PR Title Format:
Or if the count of mainly changed packages are more than 3, use
|
Please follow PR Title Format:
Or if the count of mainly changed packages are more than 3, use
|
/rebuild |
Please follow PR Title Format:
Or if the count of mainly changed packages are more than 3, use
|
/rebuild |
Please follow PR Title Format:
Or if the count of mainly changed packages are more than 3, use
|
/rebuild |
Please follow PR Title Format:
Or if the count of mainly changed packages are more than 3, use
|
/rebuild |
@ti-srebot /run-all-test |
/run-all-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
Your auto merge job has been accepted, waiting for:
|
/run-all-tests |
…also (pingcap#19341) (pingcap#21045)" This reverts commit a1bdbef.
…also (pingcap#19341) (pingcap#21045)" This reverts commit a1bdbef.
cherry-pick #19341 to release-4.0
What problem does this PR solve?
Issue Number: close #18517
Problem Summary: To fix show global variables statement return session variables.
What is changed and how it works?
What's Changed:
Rewrite the function fetchShowVariables() to distinguish global var from session var.
How it Works:
Related changes
n/a
Check List
Tests
Side effects
n/a
Release note