Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl, distsql: Support forbiding cross txnScope query all *Reader Executor #21650

Merged
merged 31 commits into from
Dec 21, 2020
Merged

ddl, distsql: Support forbiding cross txnScope query all *Reader Executor #21650

merged 31 commits into from
Dec 21, 2020

Conversation

Yisaer
Copy link
Contributor

@Yisaer Yisaer commented Dec 10, 2020 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #21426

Problem Summary:

What is changed and how it works?

Support forbidding sql query if it visits the data with the wrong txnScope for the *Reader Executor.

Tests

  • Unit test

Release note

  • No release note

@github-actions github-actions bot added sig/sql-infra SIG: SQL Infra sig/execution SIG execution labels Dec 10, 2020
@Yisaer Yisaer changed the title ddl, distsql: Support forbiding cross txnScope query ddl, distsql: Support forbiding cross txnScope query all *Reader Executor Dec 15, 2020
@Yisaer Yisaer marked this pull request as ready for review December 15, 2020 05:27
@Yisaer Yisaer requested a review from a team as a code owner December 15, 2020 05:27
@Yisaer Yisaer requested review from SunRunAway and removed request for a team December 15, 2020 05:27
@Yisaer
Copy link
Contributor Author

Yisaer commented Dec 15, 2020

@winoros @djshow832 PTAL

winoros
winoros reviewed Dec 15, 2020
View reviewed changes
distsql/request_builder.go Outdated Show resolved Hide resolved
djshow832
djshow832 reviewed Dec 15, 2020
View reviewed changes
distsql/request_builder.go Outdated Show resolved Hide resolved
distsql/request_builder.go Outdated Show resolved Hide resolved
distsql/request_builder.go Outdated Show resolved Hide resolved
@Yisaer Yisaer requested review from winoros and djshow832 December 16, 2020 06:03
djshow832
djshow832 reviewed Dec 16, 2020
View reviewed changes
Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are point get and batch point get coverred?

distsql/request_builder.go Outdated Show resolved Hide resolved
distsql/request_builder.go Outdated Show resolved Hide resolved
@Yisaer
Copy link
Contributor Author

Yisaer commented Dec 16, 2020

Are point get and batch point get coverred?

I tend to only cover RequestBuilder in this request. The checking for PointGet and any other executors will be finished in next pr.

djshow832
djshow832 reviewed Dec 17, 2020
View reviewed changes
kv/kv.go Outdated Show resolved Hide resolved
session/session_test.go Show resolved Hide resolved
djshow832
djshow832 reviewed Dec 18, 2020
View reviewed changes
Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 18, 2020
winoros
winoros reviewed Dec 21, 2020
View reviewed changes
distsql/request_builder.go Outdated Show resolved Hide resolved
winoros
winoros reviewed Dec 21, 2020
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Dec 21, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Dec 21, 2020
@Yisaer
Copy link
Contributor Author

Yisaer commented Dec 21, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 21, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit ce5ce53 into pingcap:master Dec 21, 2020
@XuHuaiyu XuHuaiyu mentioned this pull request Dec 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros left review comments

@djshow832 djshow832 djshow832 left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

@SunRunAway SunRunAway Awaiting requested review from SunRunAway

Assignees
No one assigned
Labels
component/expression sig/execution SIG execution sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Yisaer @ti-srebot @winoros @djshow832