txn: disable amend by default on master #21829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe we should also change the way to solve the schema change issue for async commit. Async commit depends on "amend" to deal with schema issues. |
Any new ideas by now? |
Use MDL-like reference counting (which we will probably implement) to control async commit too. |
|
LGTM |
ti-srebot
approved these changes
Dec 16, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
Transaction amend is not a released feature on the master branch, disable it by default. And there is still more new compatibility issues to solve like #21470.
What is changed and how it works?
What's Changed:
How it Works:
Related changes
Check List
Side effects
Release note
No release note