executor: support forbiding cross dc read for pointGet #21840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@winoros @djshow832 PTAL |
Yisaer
commented
Dec 21, 2020
| @@ -2422,7 +2422,7 @@ func (s *session) InitTxnWithStartTS(startTS uint64) error { | |||
| } | |||
|
|
|||
| // no need to get txn from txnFutureCh since txn should init with startTs | |||
| txn, err := s.store.BeginWithStartTS(oracle.GlobalTxnScope, startTS) | |||
There was a problem hiding this comment.
This would let PointGet always use global as txnScope.
There was a problem hiding this comment.
Maybe because PointGet always use max uint64 as start ts, so it doesn't matter.
djshow832
reviewed
Dec 21, 2020
|
@djshow832 we will support BatchPointGet later after #21847 is solved. |
djshow832
reviewed
Dec 22, 2020
|
@djshow832, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: execution(slack). |
ti-srebot
added
status/LGT2
ti-srebot
approved these changes
Dec 22, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #21426
Problem Summary:
What is changed and how it works?
Forbid
PointGetread data by holding wrong txnScope.Check List
Tests
Release note