Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner, expression: support enum index scan #22691

Merged
merged 9 commits into from
Apr 28, 2021
Merged

planner, expression: support enum index scan #22691

merged 9 commits into from
Apr 28, 2021

Conversation

wshwsh12
Copy link
Contributor

@wshwsh12 wshwsh12 commented Feb 3, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • No release note

@pingcap pingcap deleted a comment from sre-bot Feb 3, 2021
@wshwsh12
Copy link
Contributor Author

wshwsh12 commented Feb 3, 2021

/run-build-image

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 23, 2021
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 28, 2021
@wshwsh12 wshwsh12 marked this pull request as ready for review April 28, 2021 03:21
@wshwsh12 wshwsh12 requested review from a team as code owners April 28, 2021 03:21
@wshwsh12 wshwsh12 requested review from XuHuaiyu, lzmhhh123 and dyzsr and removed request for a team April 28, 2021 03:21
@wshwsh12
Copy link
Contributor Author

/run-all-tests

lzmhhh123
lzmhhh123 reviewed Apr 28, 2021
View reviewed changes
util/ranger/points.go Outdated
for i := range ft.Elems {
enum, err := types.ParseEnumValue(ft.Elems, uint64(i+1))
if err != nil {
continue
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about add an error log here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed

util/ranger/ranger.go
// Ignore the types.ErrorTruncated when we convert TypeEnum values.
// We should cover Enum upper overflow, and convert to the biggest value.
if point.value.GetInt64() > 0 {
upperEnum, err := types.ParseEnumValue(tp.Elems, uint64(len(tp.Elems)))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not directly Enum{}?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the enum struct is enum("a","b","c"), the condition e < 5 can convert to e <= 3, but not e <= 0.
So we need distinguish upper or lower overflow, like int type.

@wshwsh12 wshwsh12 requested a review from lzmhhh123 April 28, 2021 06:47
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 28, 2021
winoros
winoros reviewed Apr 28, 2021
View reviewed changes
util/ranger/points.go Outdated
}

for i := range ft.Elems {
enum, err := types.ParseEnumValue(ft.Elems, uint64(i+1))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use a tmp enum to avoid small objects allocation here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small objects allocation is a huge impact for ranger when the SQL is rather simple.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@wshwsh12 wshwsh12 requested a review from winoros April 28, 2021 07:12
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lzmhhh123
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 28, 2021
@wshwsh12
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@wshwsh12: /merge is only allowed for the committers in list.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@wshwsh12 wshwsh12 added the sig/execution SIG execution label Apr 28, 2021
@wshwsh12
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2543bee

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 28, 2021
@ti-chi-bot
Copy link
Member

@wshwsh12: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 8da5a1f into pingcap:master Apr 28, 2021
@wshwsh12 wshwsh12 mentioned this pull request May 10, 2021
Closed
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzmhhh123 lzmhhh123 lzmhhh123 approved these changes

@winoros winoros winoros approved these changes

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

@dyzsr dyzsr Awaiting requested review from dyzsr

Assignees
No one assigned
Labels
component/expression sig/execution SIG execution sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wshwsh12 @ti-chi-bot @winoros @lzmhhh123