store/tikv: Randomize selection of proxy store on network partition #23530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
added
the
size/M
MyonKeminta
added
sig/transaction
ti-chi-bot
added
the
size/M
|
/LGTM |
|
/run-check_dev_2 |
youjiali1995
approved these changes
Mar 25, 2021
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
ti-chi-bot
added
status/LGT2
|
/run-check_dev_2 |
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 2d58be5
|
ti-chi-bot
added
the
status/can-merge
|
/merge |
|
/run-check_dev_2 |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Mar 25, 2021
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-5.0 in PR #23560 |
ti-chi-bot
pushed a commit
that referenced
this pull request
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary: Previously, when TiDB finds a request need to be forwarded, it simply iterates over all the peers sequentially until finding one. However, if there's only 3 TiKV nodes in the cluster and the regions are rarely scheduled, most of their peer lists may have the same order, causing the selected proxy peer very likely to be imbalanced. This PR tries to randomize the first choice of the proxy peer, and iterate over the list for further retires.
What is changed and how it works?
What's Changed: Randomize selection of proxy store in GetTiKVRPCContext and OnSendFail.
How it Works:
Related changes
Check List
Tests
Release note