-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ranger: handle decimal overflow properly when building index ranges (#23535) #23551
ranger: handle decimal overflow properly when building index ranges (#23535) #23551
Conversation
Signed-off-by: ti-srebot <[email protected]>
/run-all-tests |
@eurekaka you're already a collaborator in bot's repo. |
/run-check_dev |
/run-unit-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/run-all-tests |
/run-check_dev_2 |
2 similar comments
/run-check_dev_2 |
/run-check_dev_2 |
/run-all-tests |
cherry-pick #23535 to release-5.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/23551
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #23483
Problem Summary:
Planner reports error for a query.
What is changed and how it works?
What's Changed: Ignore the overflow error for decimal type in ranger.
How it Works:
zeroMyDecimal
would be returned if overflow error occurs, soconvertPoint
would adjust theexcl
of the boundary accordingly, and impossible ranges would be removed by consequentvalidIntervals()
.Related changes
Check List
Tests
Side effects
N/A
Release note