Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ranger: handle decimal overflow properly when building index ranges (#23535) #23551

Merged
merged 4 commits into from
Mar 25, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Mar 25, 2021

cherry-pick #23535 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/23551

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/23551:release-5.0-1915517c0c0d

What problem does this PR solve?

Issue Number: close #23483

Problem Summary:

Planner reports error for a query.

What is changed and how it works?

What's Changed: Ignore the overflow error for decimal type in ranger.

How it Works: zeroMyDecimal would be returned if overflow error occurs, so convertPoint would adjust the excl of the boundary accordingly, and impossible ranges would be removed by consequent validIntervals().

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

N/A

Release note

  • Handle decimal overflow properly when building index ranges

@ti-srebot ti-srebot requested a review from a team as a code owner March 25, 2021 09:06
@ti-srebot ti-srebot requested review from winoros and removed request for a team March 25, 2021 09:06
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot added sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/5.0-cherry-pick type/bugfix This PR fixes a bug. labels Mar 25, 2021
@ti-srebot ti-srebot added this to the v5.0.0 ga milestone Mar 25, 2021
@ti-srebot
Copy link
Contributor Author

@eurekaka you're already a collaborator in bot's repo.

@eurekaka
Copy link
Contributor

/run-check_dev

@eurekaka
Copy link
Contributor

/run-unit-test

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 25, 2021
Copy link
Member

@time-and-fate time-and-fate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • time-and-fate
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 25, 2021
@eurekaka
Copy link
Contributor

/run-all-tests

@eurekaka
Copy link
Contributor

/run-check_dev_2

2 similar comments
@eurekaka
Copy link
Contributor

/run-check_dev_2

@lilinghai
Copy link
Contributor

/run-check_dev_2

@eurekaka
Copy link
Contributor

/run-all-tests

@eurekaka eurekaka merged commit 7f83879 into pingcap:release-5.0 Mar 25, 2021
@eurekaka eurekaka deleted the release-5.0-1915517c0c0d branch March 25, 2021 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/5.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants