Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add small table caching proposal #23673

Merged
merged 17 commits into from
Jun 23, 2022
Merged

docs: add small table caching proposal #23673

merged 17 commits into from
Jun 23, 2022

Conversation

tiancaiamao
Copy link
Contributor

@tiancaiamao tiancaiamao commented Mar 30, 2021 •
edited by hawkingrei
Loading

What is changed and how it works?

close #33140

Design doc for small table caching

Issue Number: ref #25293

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 30, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • morgo

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 30, 2021
@tiancaiamao tiancaiamao mentioned this pull request Jun 9, 2021
Closed
32 tasks
@tisonkun
Copy link
Contributor

Thanks for creating this design document! Closed as stale for a while. When you're going to proceed the work, please follow the design process and the new template. Looking forward to this thread revive.

@tisonkun tisonkun closed this Sep 17, 2021
@tisonkun
Copy link
Contributor

I can see that #25293 has revived and @jayl-zxl works on it. Shall we reopen this design and nudge it to merge?

@bb7133
Copy link
Member

bb7133 commented Oct 28, 2021

I can see that #25293 has revived and @jayl-zxl works on it. Shall we reopen this design and nudge it to merge?

Yes, now it is open for comments and I will re-open it.

@bb7133 bb7133 reopened this Oct 28, 2021
AilinKid
AilinKid reviewed Nov 2, 2021
View reviewed changes
docs/design/2021-03-30-small-table-caching.md Outdated Show resolved Hide resolved
docs/design/2021-03-30-small-table-caching.md Outdated Show resolved Hide resolved
docs/design/2021-03-30-small-table-caching.md Outdated Show resolved Hide resolved
docs/design/2021-03-30-small-table-caching.md Outdated Show resolved Hide resolved
docs/design/2021-03-30-small-table-caching.md Outdated Show resolved Hide resolved
docs/design/2021-03-30-small-table-caching.md Outdated Show resolved Hide resolved
docs/design/2021-03-30-small-table-caching.md Outdated Show resolved Hide resolved
@JayLZhou JayLZhou mentioned this pull request Nov 29, 2021
Merged
12 tasks
@tiancaiamao tiancaiamao marked this pull request as ready for review December 24, 2021 03:44
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 24, 2021
@sre-bot
Copy link
Contributor

sre-bot commented Dec 24, 2021 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/e0e23c3589bb2a3070e04336c51c1feed9942c8e

lcwangchao
lcwangchao reviewed Dec 24, 2021
View reviewed changes
docs/design/2021-03-30-small-table-caching.md
tid int primary key,
lock_type enum('NONE','READ','INTEND','WRITE'),
lease uint64,
oldReadLease uint64,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be old_read_lease is better to have same format with lock_type . But we should also update the exist code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes ... until recently I find this silly mistake: the naming style ...
But update this code would add another bootstrap version which is bad

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 15, 2022
@morgo morgo self-requested a review March 15, 2022 23:34
@morgo morgo mentioned this pull request Mar 29, 2022
Merged
15 tasks
bb7133
bb7133 approved these changes Jun 22, 2022
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 22, 2022
@bb7133
Copy link
Member

bb7133 commented Jun 22, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 27bcfd5

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 22, 2022
@tiancaiamao
Copy link
Contributor Author

/merge

@hawkingrei hawkingrei added skip-issue-check Indicates that a PR no need to check linked issue. and removed skip-issue-check Indicates that a PR no need to check linked issue. labels Jun 23, 2022
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 23, 2022
@ti-chi-bot ti-chi-bot merged commit 095e323 into pingcap:master Jun 23, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jun 23, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-ddl-test 🟥 failed 1, success 5, total 6 16 min New failing
idc-jenkins-ci-tidb/tics-test 🔴 failed 1, success 0, total 1 4 min 3 sec Existing failure
idc-jenkins-ci-tidb/integration-common-test ✅ all 11 tests passed 20 min Fixed
idc-jenkins-ci/integration-cdc-test 🟢 all 35 tests passed 23 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 12 tests passed 11 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 9 min 34 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 6 min 33 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 44 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 33 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@tiancaiamao tiancaiamao deleted the cache-table-proposal branch June 23, 2022 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcwangchao lcwangchao lcwangchao left review comments

@AilinKid AilinKid AilinKid left review comments

@morgo morgo morgo approved these changes

@bb7133 bb7133 bb7133 approved these changes

@tangenta tangenta Awaiting requested review from tangenta

@hawkingrei hawkingrei Awaiting requested review from hawkingrei

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write design doc for the table cache feature
9 participants
@tiancaiamao @ti-chi-bot @tisonkun @bb7133 @sre-bot @morgo @lcwangchao @AilinKid @hawkingrei