Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: tidb panic while query hash partition table with is null condition #23849

Merged
merged 26 commits into from
Jun 7, 2021
Merged

ddl: tidb panic while query hash partition table with is null condition #23849

merged 26 commits into from
Jun 7, 2021

Conversation

Howie59
Copy link
Contributor

@Howie59 Howie59 commented Apr 5, 2021

What problem does this PR solve?

Issue Number: close #23802

Check List

Tests

  • Unit test

Release note

  • No release note

@Howie59 Howie59 requested a review from a team as a code owner April 5, 2021 13:12
@Howie59 Howie59 requested review from winoros and removed request for a team April 5, 2021 13:12
@ti-chi-bot ti-chi-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 5, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 5, 2021
@xiongjiwei
Copy link
Contributor

ping! can you please resolve the confilits?

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 10, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 13, 2021
@qw4990 qw4990 added the type/bugfix This PR fixes a bug. label Jun 4, 2021
@ti-chi-bot
Copy link
Member

@djshow832: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@djshow832 djshow832 added the sig/sql-infra SIG: SQL Infra label Jun 7, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 7, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • djshow832
  • qw4990

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 7, 2021
@qw4990
Copy link
Contributor

qw4990 commented Jun 7, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 02ae9d4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 7, 2021
@ti-chi-bot ti-chi-bot merged commit 5005bc0 into pingcap:master Jun 7, 2021
@qw4990
Copy link
Contributor

qw4990 commented Jun 8, 2021

/run-cherry-picker

@ti-srebot ti-srebot mentioned this pull request Jun 8, 2021
Merged
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 8, 2021
@Howie59 @ti-srebot
cherry pick pingcap#23849 to release-5.1
3e68eae 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #25228

@Howie59 Howie59 deleted the issue-23802 branch June 10, 2021 05:07
ti-chi-bot pushed a commit that referenced this pull request Jun 11, 2021
@ti-srebot
ddl: tidb panic while query hash partition table with is null conditi…
f91afa9 
…on (#23849) (#25228)
@time-and-fate
Copy link
Member

/label needs-cherry-pick-5.0

@time-and-fate
Copy link
Member

/run-cherry-picker

@ti-srebot ti-srebot mentioned this pull request Aug 6, 2021
Merged
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 6, 2021
@Howie59 @ti-srebot
cherry pick pingcap#23849 to release-5.0
a2db40c 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #26963

@time-and-fate time-and-fate mentioned this pull request Aug 6, 2021
Closed
ti-chi-bot pushed a commit that referenced this pull request Aug 30, 2021
@ti-srebot
ddl: tidb panic while query hash partition table with is null conditi…
2fa21e3 
…on (#23849) (#26963)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjonss mjonss mjonss approved these changes

@qw4990 qw4990 qw4990 approved these changes

@djshow832 djshow832 djshow832 approved these changes

@winoros winoros Awaiting requested review from winoros

@rebelice rebelice Awaiting requested review from rebelice

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 sig/planner SIG: Planner sig/sql-infra SIG: SQL Infra size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tidb panic while query hash partition table with is null condition
8 participants
@Howie59 @xiongjiwei @ti-chi-bot @qw4990 @ti-srebot @time-and-fate @mjonss @djshow832