Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: Implement PointGet in TryFastPlan for range/list paritition table #24588

Merged
merged 49 commits into from
May 21, 2021
Merged

planner: Implement PointGet in TryFastPlan for range/list paritition table #24588

merged 49 commits into from
May 21, 2021

Conversation

zhuo-zhi
Copy link
Contributor

What problem does this PR solve?

Issue Number: related to #24476, #24150

Problem Summary:

  • planner: Implement PointGet in TryFastPlan for range/list paritition table. Will implement BatchGet in the next PR.

What is changed and how it works?

What's Changed:

  • Change the tryPointGetPlan logic. Let it permit other types of partition table other than hash partition table. Add logic to locate partition table.

How it Works:

  • After getting paris variable, we use it to locate the partition where data point lies.

Check List

Tests

  • Unit test

Side effects

  • N/A

Release note

  • planner: Implement PointGet in TryFastPlan for range/list paritition table

@zhuo-zhi zhuo-zhi requested a review from a team as a code owner May 12, 2021 10:13
@zhuo-zhi zhuo-zhi requested review from rebelice and removed request for a team May 12, 2021 10:13
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 12, 2021
@zhuo-zhi zhuo-zhi marked this pull request as draft May 12, 2021 10:13
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 12, 2021
@zhuo-zhi
Copy link
Contributor Author

Leave some unit tests to be added soon.

@qw4990
Copy link
Contributor

qw4990 commented May 12, 2021

/merge

@ti-chi-bot
Copy link
Member

@qw4990: /merge in this pull request requires 2 /lgtm.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@github-actions github-actions bot added the sig/execution SIG execution label May 12, 2021
@zhuo-zhi zhuo-zhi marked this pull request as ready for review May 12, 2021 13:02
@zhuo-zhi zhuo-zhi requested a review from a team as a code owner May 12, 2021 13:02
@zhuo-zhi zhuo-zhi requested review from wshwsh12 and removed request for a team May 12, 2021 13:02
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 12, 2021
@zhuo-zhi
Copy link
Contributor Author

/cc @qw4990

@ti-chi-bot ti-chi-bot requested a review from qw4990 May 12, 2021 13:04
@qw4990 qw4990 requested a review from mjonss May 13, 2021 06:57
@qw4990 qw4990 added the sig/planner SIG: Planner label May 13, 2021
@zhuo-zhi
Copy link
Contributor Author

/run-all-tests

2 similar comments
@qw4990
Copy link
Contributor

qw4990 commented May 21, 2021

/run-all-tests

@zhuo-zhi
Copy link
Contributor Author

/run-all-tests

@zhuo-zhi
Copy link
Contributor Author

/run-check_dev_2

@zhuo-zhi
Copy link
Contributor Author

/run-common-test

@zhuo-zhi
Copy link
Contributor Author

/run-integration-common-test

@zhuo-zhi
Copy link
Contributor Author

/run-common-test

@zhuo-zhi
Copy link
Contributor Author

/run-integration-common-test

1 similar comment
@zhuo-zhi
Copy link
Contributor Author

/run-integration-common-test

@zhuo-zhi
Copy link
Contributor Author

/run-common-test

@zhuo-zhi
Copy link
Contributor Author

/run-check_dev_2

@qw4990
Copy link
Contributor

qw4990 commented May 21, 2021

/merge

@zhuo-zhi
Copy link
Contributor Author

/run-check_dev_2

@zhuo-zhi
Copy link
Contributor Author

/run-common-test

@zhuo-zhi
Copy link
Contributor Author

/run-integration-common-test

@ti-chi-bot
Copy link
Member

/run-all-tests

This bot automatically retries jobs that failed on can merge PRs (send feedback to hi-rustin).

Silence the bot with the /merge cancel comment for consistent failures.

@purelind
Copy link
Contributor

/run-all-tests

@xhebox
Copy link
Contributor

xhebox commented May 21, 2021

/run-all-tests tidb-test=pr/1198

@xhebox
*: fix CI
3eb099d 
Signed-off-by: xhe <[email protected]>
@ti-chi-bot
Copy link
Member

Merge canceled because a new commit is pushed.

@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed status/can-merge Indicates a PR has been approved by a committer. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 21, 2021
@xhebox
*: fix CI 2
9744f72 
Signed-off-by: xhe <[email protected]>
@xhebox
Copy link
Contributor

xhebox commented May 21, 2021

/run-all-tests tidb-test=pr/1198

@xhebox
Copy link
Contributor

xhebox commented May 21, 2021

/run-check_dev_2 tidb-test=pr/1198
/run-common-test tidb-test=pr/1198
/run-integration-common-test tidb-test=pr/1198

@xhebox
*: fix CI 3
4c9c20c 
Signed-off-by: xhe <[email protected]>
@zhouqiang-cl zhouqiang-cl merged commit 163eb5f into pingcap:master May 21, 2021
@qw4990 qw4990 mentioned this pull request Jun 8, 2021
Closed
@tisonkun tisonkun added the sig/sql-infra SIG: SQL Infra label Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebelice rebelice rebelice approved these changes

@qw4990 qw4990 qw4990 approved these changes

@wshwsh12 wshwsh12 Awaiting requested review from wshwsh12

@mjonss mjonss Awaiting requested review from mjonss

Assignees
No one assigned
Labels
sig/execution SIG execution sig/planner SIG: Planner sig/sql-infra SIG: SQL Infra size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@zhuo-zhi @qw4990 @ti-chi-bot @Rustin170506 @purelind @xhebox @rebelice @tisonkun @zhouqiang-cl