Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expresssion: determine the field type of control function with enum type (#24830) #24915

Closed

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented May 27, 2021

cherry-pick #24830 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/24915

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/24915:release-5.0-2f96bc7502ac

What problem does this PR solve?

Issue Number: close #24543

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:
Determine the field type of control function with enum type. If the return fieldtype is enum, we can use the evaltype to determine the fieldtype.

How it Works:

Related changes

Check List

Tests

  • Unit test
  • Integration test

Side effects

Release note

  • If unexpect panic for control function

@ti-srebot ti-srebot requested a review from a team as a code owner May 27, 2021 03:46
@ti-srebot ti-srebot requested review from wshwsh12 and removed request for a team May 27, 2021 03:46
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot
Copy link
Member

@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved (/lgtm + /merge) by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot added component/expression size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/5.0-cherry-pick type/bugfix This PR fixes a bug. labels May 27, 2021
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 27, 2021
@ti-srebot ti-srebot added this to the v5.0.1 milestone May 27, 2021
@ti-srebot
Copy link
Contributor Author

@wshwsh12 you're already a collaborator in bot's repo.

@wshwsh12 wshwsh12 removed their request for review June 3, 2021 05:10
@wshwsh12 wshwsh12 closed this Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression do-not-merge/cherry-pick-not-approved size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/bugfix This PR fixes a bug. type/5.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants