Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infoschema: Remove the unimplemented ALL_SQL_DIGESTS column from the DEADLOCKS table #24939

Merged
merged 3 commits into from
May 27, 2021
Merged

infoschema: Remove the unimplemented ALL_SQL_DIGESTS column from the DEADLOCKS table #24939

merged 3 commits into from
May 27, 2021

Conversation

MyonKeminta
Copy link
Contributor

@MyonKeminta MyonKeminta commented May 27, 2021 •
edited
Loading

What problem does this PR solve?

Problem Summary: The ALL_SQL_DIGESTS column of the information_schema.deadlocks table is not implement yet and we plan to release the first version without that column. The column has been added to the table but it content is always null. To avoid confusing the user, remove it for now and add it in the future when we implement the whole thing.

Ref: Lock View

What is changed and how it works?

What's Changed: The ALL_SQL_DIGESTS column in information_schema.deadlocks is removed.

Related changes

Check List

Tests

  • Unit test

Side effects

Release note

  • No release note.

@MyonKeminta MyonKeminta added the sig/transaction SIG:Transaction label May 27, 2021
@MyonKeminta MyonKeminta requested a review from a team as a code owner May 27, 2021 12:11
@MyonKeminta MyonKeminta requested review from qw4990 and removed request for a team May 27, 2021 12:11
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 27, 2021
cfzjywxk
cfzjywxk reviewed May 27, 2021
View reviewed changes
Copy link
Contributor

@cfzjywxk cfzjywxk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 27, 2021
@MyonKeminta MyonKeminta mentioned this pull request May 27, 2021
Closed
20 tasks
youjiali1995
youjiali1995 reviewed May 27, 2021
View reviewed changes
util/deadlockhistory/deadlock_history.go Outdated
Comment on lines 153 to 157
// TODO: Implement the ALL_SQL_DIGESTS column for the deadlock table.
//row[7] = nil
//if item.AllSQLDigests != nil {
// row[7] = "[" + strings.Join(item.AllSQLDigests, ", ") + "]"
//}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to delete them and comment out the column definition. 😕

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Is this what you mean?

@github-actions github-actions bot added sig/execution SIG execution sig/sql-infra SIG: SQL Infra labels May 27, 2021
@MyonKeminta
fix tests; address comment
e9dcdeb 
Signed-off-by: MyonKeminta <[email protected]>
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • cfzjywxk
  • youjiali1995

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 27, 2021
@youjiali1995
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e9dcdeb

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 27, 2021
@ti-chi-bot
Copy link
Member

@MyonKeminta: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

/run-all-tests

This bot automatically retries jobs that failed on can merge PRs (send feedback to hi-rustin).

Silence the bot with the /merge cancel comment for consistent failures.

@ti-chi-bot ti-chi-bot merged commit b64f900 into pingcap:master May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfzjywxk cfzjywxk cfzjywxk left review comments

@youjiali1995 youjiali1995 youjiali1995 approved these changes

@qw4990 qw4990 Awaiting requested review from qw4990

Assignees
No one assigned
Labels
sig/execution SIG execution sig/sql-infra SIG: SQL Infra sig/transaction SIG:Transaction size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MyonKeminta @ti-chi-bot @youjiali1995 @cfzjywxk