-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
session: Fix txn.onStmtEnd is not called when some special error occurs in ExecutePreparedStmt #26056
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/merge |
@cfzjywxk: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 8159237
|
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-5.1 in PR #26080 |
What problem does this PR solve?
Problem Summary:
In this part of code, previously it calls
onStmtStart
, calculates the result, callsonStmtEnd
, and return the result. However later some modification to this code adds some more return statements between theonStmtStart
andonStmtEnd
calls, which makes theonStmtEnd
not called in some rare cases. This PR fixes it by callingonStmtEnd
in defer statement.What is changed and how it works?
What's Changed: Call the
onStmtEnd
in defer stmt.Related changes
Check List
Tests
Side effects
Release note