executor: Support collecting information about retryable deadlocks to information_schema.deadlocks #26140
Conversation
ti-chi-bot
added
the
size/S
…ct-retryable-deadlock
github-actions
bot
added
component/config
sig/execution
| rec := deadlockhistory.ErrDeadlockToDeadlockRecord(deadlock) | ||
| deadlockhistory.GlobalDeadlockHistory.Push(rec) | ||
| cfg := config.GetGlobalConfig() | ||
| if deadlock.IsRetryable && !cfg.PessimisticTxn.DeadlockHistoryCollectRetryable { |
There was a problem hiding this comment.
If a retryable deadlock occurs many times, can it pollute the deadlock histroy?
There was a problem hiding this comment.
Yes. So I make it not collected by default.
There was a problem hiding this comment.
I'm afraid it's never turned on because it can't be changed online. For retryable deadlock, it's better to merge the error from the same statements and record its retry count.
There was a problem hiding this comment.
I plan to make it support online-changing via the http api. But, you are right, merging repeated error is a good idea. I'll reconsider it.
There was a problem hiding this comment.
To make an record to become latest when updating the retry count of an existing record, It seems we need to change the deadlock history collection (which is a simple queue now) into an LRU. @youjiali1995
There was a problem hiding this comment.
I didn't support merging repeated error for now since it needs too much code change, but I added the HTTP API. PTAL again. @youjiali1995 @longfangsong
…ct-retryable-deadlock
ti-chi-bot
added
size/M
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: f5444c4
|
ti-chi-bot
added
the
status/can-merge
|
@MyonKeminta: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Problem Summary: This PR is part of Lock View. It supports collecting retryable (in-statement) deadlocks. It's by default not collected, but it can be enabled by config.
What is changed and how it works?
What's Changed: Supports collecting retryable deadlock errors.
Check List
Tests
Side effects
Documentation
Release note