-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: prevent function of castYearAsTime from pushing down to Ti… (#25975) #26370
expression: prevent function of castYearAsTime from pushing down to Ti… (#25975) #26370
Conversation
Signed-off-by: ti-srebot <[email protected]>
/run-all-tests |
@mengxin9014 please accept the invitation then you can push to the cherry-pick pull requests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 5f42ce3
|
cherry-pick #25975 to release-5.1
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/26370
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: pingcap/tiflash#1964
Problem Summary:
The type of year operation with the type of date is wrong, for example:
except:
actual:
What is changed and how it works?
the problem is because that the column
a
of type year handled by function of castIntAsTime is pushed down to Tiflash.Tiflash cannot recognize type year without field type, so cast the column a as time incorrectly.
Temporarily stop pushing down the function of castIntAsTime to TiFlash to get the correctly record.
Release note