Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statistics: trigger auto-analyze based on histogram row count (#24382) #26706

Merged
merged 4 commits into from
Sep 10, 2021
Merged

statistics: trigger auto-analyze based on histogram row count (#24382) #26706

merged 4 commits into from
Sep 10, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jul 28, 2021 •
edited
Loading

cherry-pick #24382 to release-4.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/26706

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/26706:release-4.0-50ae2d8266b9

What problem does this PR solve?

Issue Number: close #24237, related to #26282

Problem Summary:

Trigger auto analyze in a more proper way.

What is changed and how it works?

What's Changed:

Use the histogram row count as the base count for checking auto analyze, instead of the Count in Table.

Related changes

N/A

Check List

Tests

  • Unit test

Side effects

N/A

Release note

  • Trigger auto-analyze based on histogram row count

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 28, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qw4990
  • time-and-fate

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

@ti-srebot: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Jul 28, 2021
@ti-srebot ti-srebot mentioned this pull request Jul 28, 2021
Merged
@ti-srebot ti-srebot added component/statistics sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/4.0-cherry-pick type/enhancement The issue or PR belongs to an enhancement. labels Jul 28, 2021
@ti-srebot ti-srebot added this to the v4.0.14 milestone Jul 28, 2021
@ti-chi-bot ti-chi-bot removed the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 28, 2021
@ti-srebot
Copy link
Contributor Author

@eurekaka you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 28, 2021
@zhouqiang-cl zhouqiang-cl removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Aug 4, 2021
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 10, 2021
@time-and-fate time-and-fate mentioned this pull request Aug 13, 2021
Merged
12 tasks
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 13, 2021
@ti-chi-bot ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Aug 13, 2021
@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Aug 13, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Sep 10, 2021
@Reminiscent
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5dddba8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 10, 2021
@ti-chi-bot ti-chi-bot merged commit 4b8d5cb into pingcap:release-4.0 Sep 10, 2021
@zhouqiang-cl zhouqiang-cl modified the milestones: v4.0.14, v4.0.15 Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@time-and-fate time-and-fate time-and-fate approved these changes

@qw4990 qw4990 qw4990 approved these changes

@winoros winoros Awaiting requested review from winoros

Assignees

@eurekaka eurekaka

Labels
cherry-pick-approved Cherry pick PR approved by release team. component/statistics sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement. type/4.0-cherry-pick
Projects
None yet
Milestone
v4.0.15
Development

Successfully merging this pull request may close these issues.
7 participants
@ti-srebot @ti-chi-bot @Reminiscent @qw4990 @time-and-fate @eurekaka @zhouqiang-cl