-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: Add missing pbcode for functions InetAton/InetNtoa/Inet6Aton/Inet6Ntoa/IsIPv4/IsIPv4Compat/IsIPv4Mapped/IsIPv6
.
#26939
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/cc @fuzhe1989 |
@LittleFall: GitHub didn't allow me to request PR reviews from the following users: fuzhe1989. Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@fuzhe1989: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
InetAton/InetNtoa/Inet6Aton/Inet6Ntoa/IsIPv4/IsIPv4Compat/IsIPv4Mapped/IsIPv6
.
//jsonColumn := dg.genColumn(mysql.TypeJSON, 1) | ||
//intColumn := dg.genColumn(mysql.TypeLonglong, 2) | ||
//realColumn := dg.genColumn(mysql.TypeDouble, 3) | ||
//decimalColumn := dg.genColumn(mysql.TypeNewDecimal, 4) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
later will use
/rebuild |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 94473eb
|
[2021-08-06T07:22:54.680Z] Using context: idc-jenkins-ci-tidb/check_dev [2021-08-06T07:22:55.350Z] java.lang.InterruptedException [2021-08-06T07:22:55.350Z] at java.lang.Object.wait(Native Method) [2021-08-06T07:22:55.350Z] at java.lang.Object.wait(Object.java:502) [2021-08-06T07:22:55.350Z] at java.lang.UNIXProcess.waitFor(UNIXProcess.java:395) [2021-08-06T07:22:55.350Z] at hudson.Proc$LocalProc.join(Proc.java:327) [2021-08-06T07:22:55.350Z] at hudson.Proc.joinWithTimeout(Proc.java:172) [2021-08-06T07:22:55.350Z] at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2632) [2021-08-06T07:22:55.350Z] at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:2079) [2021-08-06T07:22:55.350Z] at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$500(CliGitAPIImpl.java:84) [2021-08-06T07:22:55.350Z] at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:601) [2021-08-06T07:22:55.350Z] at jenkins.plugins.git.GitSCMFileSystem$BuilderImpl.build(GitSCMFileSystem.java:365) [2021-08-06T07:22:55.350Z] at jenkins.scm.api.SCMFileSystem.of(SCMFileSystem.java:197) [2021-08-06T07:22:55.350Z] at jenkins.scm.api.SCMFileSystem.of(SCMFileSystem.java:173) [2021-08-06T07:22:55.350Z] at org.jenkinsci.plugins.workflow.cps.CpsScmFlowDefinition.create(CpsScmFlowDefinition.java:114) [2021-08-06T07:22:55.350Z] at org.jenkinsci.plugins.workflow.cps.CpsScmFlowDefinition.create(CpsScmFlowDefinition.java:68) [2021-08-06T07:22:55.350Z] at org.jenkinsci.plugins.workflow.job.WorkflowRun.run(WorkflowRun.java:309) [2021-08-06T07:22:55.350Z] at hudson.model.ResourceController.execute(ResourceController.java:97) [2021-08-06T07:22:55.350Z] at hudson.model.Executor.run(Executor.java:429) [2021-08-06T07:22:55.350Z] Finished: FAILURE |
CI fails for many times
|
/merge |
my code failed, fixed |
[2021-08-06T08:02:11.933Z] + rm -rf /tmp/tidb [2021-08-06T08:02:11.933Z] + mkdir -p plugin-so [2021-08-06T08:02:11.933Z] + cp /home/jenkins/agent/workspace/tidb_ghpr_build/go/src/github.com/pingcap/enterprise-plugin/audit/audit-1.so ./plugin-so/ [2021-08-06T08:02:11.933Z] + cp /home/jenkins/agent/workspace/tidb_ghpr_build/go/src/github.com/pingcap/enterprise-plugin/whitelist/whitelist-1.so ./plugin-so/ [2021-08-06T08:02:12.192Z] + sleep 5 [2021-08-06T08:02:12.192Z] + /home/jenkins/agent/workspace/tidb_ghpr_build/go/src/github.com/pingcap/tidb/bin/tidb-server -plugin-dir=/home/jenkins/agent/workspace/tidb_ghpr_build/go/src/github.com/pingcap/tidb/plugin-so -plugin-load=audit-1,whitelist-1 [2021-08-06T08:02:17.453Z] + mysql -h 127.0.0.1 -P 4000 -u root -e 'select tidb_version()' [2021-08-06T08:02:17.453Z] ERROR 2003 (HY000): Can't connect to MySQL server on '127.0.0.1' (111) |
/merge |
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-5.0 in PR #26960 |
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-5.1 in PR #26961 |
What problem does this PR solve?
Issue Number: close #26942
Problem Summary: some scalar function hasn't pdcode for some reason, so it can't be pushed down as expected.
What is changed and how it works?
Proposal: xxx
What's Changed:
How it Works:
Check List
Tests
Side effects
Documentation
Release note