information_schema: Fill information_schema.key_column_usage #2721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenli
force-pushed
the
shenli/key-column-usage
branch
from
8ff23ab to
3fd6374
Compare
shenli
changed the title
hanfei1991
reviewed
May 11, 2017
infoschema/tables.go
Outdated
| for _, table := range schema.Tables { | ||
| rs := keyColumnUsageInTable(schema, table) | ||
| for _, r := range rs { | ||
| rows = append(rows, r) |
infoschema/tables.go
Outdated
| @@ -847,6 +848,103 @@ func dataForTableConstraints(schemas []*model.DBInfo) [][]types.Datum { | |||
| return rows | |||
| } | |||
|
|
|||
| func dataForKeyColumnUsage(schemas []*model.DBInfo) [][]types.Datum { | |||
| rows := [][]types.Datum{} | |||
tiancaiamao
reviewed
May 11, 2017
| schema.Name.O, // TABLE_SCHEMA | ||
| table.Name.O, // TABLE_NAME | ||
| col.Name.O, // COLUMN_NAME | ||
| i+1, // ORDINAL_POSITION, |
There was a problem hiding this comment.
why it's i+1 here, but line 877 is i ?
There was a problem hiding this comment.
Line 877 should be 1.
The value of ORDINAL_POSITION is the column's position within the constraint, not the column's position within the table. Column positions are numbered beginning with 1.
So for PkAsHandle, it should always be 1.
|
@tiancaiamao @hanfei1991 PTAL |
|
LGTM |
zimulala
reviewed
May 12, 2017
infoschema/tables.go
Outdated
| @@ -847,6 +848,101 @@ func dataForTableConstraints(schemas []*model.DBInfo) [][]types.Datum { | |||
| return rows | |||
| } | |||
|
|
|||
| func dataForKeyColumnUsage(schemas []*model.DBInfo) [][]types.Datum { | |||
| rows := make([][]types.Datum, len(schemas)) // The capacity is not accurate, but it is not a big problem. | |||
There was a problem hiding this comment.
-> make([][]types.Datum, 0, len(schemas)) ?
|
LGTM |
zimulala
approved these changes
May 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add content for key-column-usage table.
@zimulala @tiancaiamao @XuHuaiyu PTAL