-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
session: Add failpoint session/beforeLoockKeys #27332
session: Add failpoint session/beforeLoockKeys #27332
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Can |
Its problem is that it also blocks the query to TIDB_TRX. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 1878448
|
@vivid392845427: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-5.2 in PR #27341 |
What problem does this PR solve?
Problem Summary: Currently it's not very easy to construct a case in test that can stably get
Running
state transactions in TIDB_TRX tables. This PR adds a failpoint at a place just before starting acquiring locks. This helps in integration tests.What is changed and how it works?
What's Changed: Adds failpoint
github.com/pingcap/tidb/session/beforeLockKeys
Check List
Tests
Side effects
None
Documentation
None
Release note