Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session: Add failpoint session/beforeLoockKeys #27332

Merged
merged 6 commits into from
Aug 18, 2021

Conversation

MyonKeminta
Copy link
Contributor

What problem does this PR solve?

Problem Summary: Currently it's not very easy to construct a case in test that can stably get Running state transactions in TIDB_TRX tables. This PR adds a failpoint at a place just before starting acquiring locks. This helps in integration tests.

What is changed and how it works?

What's Changed: Adds failpoint github.com/pingcap/tidb/session/beforeLockKeys

Check List

Tests

  • Integration test

Side effects

  • None
    Documentation

  • None

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 18, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • cfzjywxk
  • longfangsong

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 18, 2021
@longfangsong
Copy link
Contributor

Currently it's not very easy to construct a case in test that can stably get Running state transactions in TIDB_TRX tables.

Can github.com/pingcap/tidb/session/mockStmtSlow (though might need a better name) archieve this goal?

@MyonKeminta
Copy link
Contributor Author

Currently it's not very easy to construct a case in test that can stably get Running state transactions in TIDB_TRX tables.

Can github.com/pingcap/tidb/session/mockStmtSlow (though might need a better name) archieve this goal?

Its problem is that it also blocks the query to TIDB_TRX.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 18, 2021
@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Aug 18, 2021
Copy link
Contributor

@cfzjywxk cfzjywxk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 18, 2021
@MyonKeminta
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1878448

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 18, 2021
@ti-chi-bot
Copy link
Member

@vivid392845427: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 9a307a0 into pingcap:master Aug 18, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 18, 2021
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #27341

@MyonKeminta MyonKeminta deleted the m/add-failpoint-beforeLockKeys branch August 18, 2021 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-5.2 release-note-none Denotes a PR that doesn't merit a release note. sig/sql-infra SIG: SQL Infra sig/transaction SIG:Transaction size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants