*: support select for update of tables

[jackysp]

Signed-off-by: Shuaipeng Yu [email protected]

What problem does this PR solve?

Issue Number: close #28689

Problem Summary:
For a multi-table join, a for update stmt locks all tables, some tables may only be read-only tables that participate in it.

What is changed and how it works?

Proposal: xxx

What's Changed:
Supports the of tables syntax, which specifies that only some of the tables are locked.

How it Works:

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Support `of table list` clause for `select for update` statement.

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• cfzjywxk
• coocood

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[jackysp]

Merge pingcap/parser#1333 first.

[jackysp]

PTAL @cfzjywxk @coocood

[cfzjywxk]

@jackysp
As it will introduce a new feature, do we need to sync with the production manager for this change?

[jackysp]

@jackysp As it will introduce a new feature, do we need to sync with the production manager for this change?

I am not familiar with the R&D process. But how are all the new features contributed by the community? @cfzjywxk

[cfzjywxk]

@jackysp As it will introduce a new feature, do we need to sync with the production manager for this change?

I am not familiar with the R&D process. But how are all the new features contributed by the community? @cfzjywxk

@jackysp
Seems the behaviour and feature change needs to be approved by the product manager by now, let me check about it.

[cfzjywxk]

@jackysp
Currently the R&D process is that extra change or contribution needs to be approved by @sunxiaoguang, after that this could be packed into the sprint6 release box.

[sunxiaoguang]

Hi @jackysp , Thanks for your contribution.

As on going discussion on internals proposed. Despite the fact that we haven't decided with implementation mechanism, Community already reached agreement on always attaching issue to PR. So could you please create an issue to describe the feature you implemented and use #close xxx in PR message to link the issue and PR.

Thanks.

[tisonkun]

Hi @jackysp , Thanks for your contribution.

As on going discussion on (internals)[https://internals.tidb.io/t/topic/409/60] proposed. Despite the fact that we haven't decided with implementation mechanism, Community already reached agreement on always attaching issue to PR. So could you please create an issue to describe the feature you implemented and use #close xxx in PR message to link the issue and PR.

Thanks.

This's a good suggestion.

@jackysp I'd emphasize that it's not formalism, but we withdraw to the proposal phase that you will introduce a new feature with some motivation and background.

We have to reach a consensus on whether we want this feature and how we plan to implement it in the community by decision making involves other maintainers (you're one of maintainers) and committers. And later go into the implementation and test phase. Later released.

See more information on Make a Proposal.

[jackysp]

PTAL @cfzjywxk

[cfzjywxk]

LGTM

[jackysp]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 9c2190c

[ti-chi-bot]

@jackysp: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.