Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inforschema, executor: add push down for tikv_region_peers #28211

Closed
wants to merge 20 commits into from
Closed

Inforschema, executor: add push down for tikv_region_peers #28211

wants to merge 20 commits into from

Conversation

IcePigZDB
Copy link
Contributor

@IcePigZDB IcePigZDB commented Sep 19, 2021 •
edited
Loading

What problem does this PR solve?

Tracking Issue: #28330

Problem Summary:
push down for tikv_region_peers.

What is changed and how it works?

add TikvRegionPeersExtractor to push down STORE_ID and REGION_ID.
add tikvRegionPeersRetriever to fetch regions information from PD.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note 

None

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 19, 2021
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 23, 2021
@IcePigZDB IcePigZDB mentioned this pull request Sep 25, 2021
Open
5 tasks
@qidi1 qidi1 mentioned this pull request Sep 25, 2021
Closed
12 tasks
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 25, 2021
@IcePigZDB IcePigZDB marked this pull request as ready for review September 27, 2021 05:11
@IcePigZDB IcePigZDB changed the title [WIP] Infoschema: add push down for tikv_region_peers Infoschema: add push down for tikv_region_peers Sep 27, 2021
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 27, 2021
@IcePigZDB IcePigZDB marked this pull request as draft November 23, 2021 11:44
@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 23, 2021
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 29, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 29, 2021
@IcePigZDB
Copy link
Contributor Author

/run-all-tests

@IcePigZDB IcePigZDB marked this pull request as ready for review November 30, 2021 01:59
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 30, 2021
@CLAassistant
Copy link

CLAassistant commented Nov 30, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@IcePigZDB IcePigZDB changed the title Infoschema: add push down for tikv_region_peers Inforschema, executor: add push down for tikv_region_peers Dec 8, 2021
This was referenced Dec 12, 2021
Open
Open
@IcePigZDB
Copy link
Contributor Author

IcePigZDB commented Dec 13, 2021 •
edited
Loading

split into two small pr:

@sre-bot
Copy link
Contributor

sre-bot commented Dec 21, 2021

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/b8277f933924d9ff49747374f934726c8779c9a8

@IcePigZDB
Copy link
Contributor Author

close by PRs split from this PR, which are list above.

@IcePigZDB IcePigZDB closed this Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IcePigZDB @ti-chi-bot @CLAassistant @sre-bot