-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logutil: force level of slow logger to "debug" #28688
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please fill the release note, and pick up suitable release versions. |
@SabaPing PTAL |
I will back to this issue late afternoon today. |
@SabaPing Do you have updates~? |
Ahhh, I spent more time than expected on development yesterday, and I also handled a few oncalls on cloud in the afternoon, so I really didn't have time. I hope I can handle this issue this afternoon. |
Manual test steps:
|
Fixed in #30461. |
What problem does this PR solve?
Fix oncall issue https://internal.pingcap.net/jira/browse/ONCALL-3746.
Setting TiDB's
log.level
toerror
causes that the slow log does not print.One must set the
log.level
toinfo
orwarn
via tiup cluster edit-config and reload the TiDB node to re-enable the slow logs.This PR fix this issue. After fixing, global
log.level
should not affects slow logs.Manual test steps
Start TiDB with command line arguement -L=error.
Slow logs should output normally.
Release note