*: resolve select fields properly for coalesced columns of natural join (#25094)

[ti-srebot]

cherry-pick #25094 to release-5.1
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/30050

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/30050:release-5.1-ead31402bccd

---

What problem does this PR solve?

Issue Number: close #25041

Problem Summary:

Incompatible error when grouping on join.

What is changed and how it works?

What's Changed:

Specially mark the redundant columns incurred by natural join / using keyword in FieldName, and ignore them when resolving columns.

How it Works:

The problem was incurred by #21922 when trying to fix #6712. #21922 exposes the columns in redundantSchema to the schema of aggregation, which led to the ambiguity.

I have tried reverting the #21922 patch and finding the column in LogicalJoin.redundantSchema recursively when resolving the select fields, it can work in the plan building step, but would fail in the final ResolveIndices, because aggregation is a schema producer.

Related changes

N/A

Check List

Tests

• Unit test

Side effects

N/A

Release note

Resolve select fields properly for coalesced columns of natural join

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• time-and-fate
• winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[ti-srebot]

/run-all-tests

[ti-chi-bot]

@ti-srebot: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ti-chi-bot]

@ti-srebot: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ti-srebot]

@eurekaka you're already a collaborator in bot's repo.

[time-and-fate]

/run-mysql-test

[time-and-fate]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: ac1cd37

[time-and-fate]

/run-check_dev