-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: fix some unit test funcion that can't run independently #31086
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
It's for #30822 |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/1d30629bdf55fccc3efc55fd9b0b548b0edd2e2b |
/run-check_dev_2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this empty line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 4aa055f
|
@tiancaiamao: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: close #31085
Problem Summary:
Some test cases can't run independently:
or
It reports an error "[ddl:-1]failed to notify PD the placement rules: infoSyncer is not initialized"
What is changed and how it works?
When the test case run with others, the global variable is initialized by other test cases
tidb/domain/infosync/info.go
Lines 168 to 170 in 61d13b5
This is a workaround to make it possible to run the single test case.
Modification on
tools/check/ut.go
is unrelated to this fix, it just make the output easier for debugging.Check List
Tests
Side effects
Documentation
Release note