Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: enable more flaky test, enable more shard_count and update bazel config #35300

Merged
merged 6 commits into from
Jun 13, 2022

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Jun 10, 2022

Signed-off-by: Weizhen Wang [email protected]

What problem does this PR solve?

Issue Number: ref #35247

Problem Summary:

What is changed and how it works?

  • enable more flaky test
  • enable more shard_count
  • split test cases into subdirectories to speed up the build and the test.

Why are test cases speed up by being splited into subdirectories?

1、execute has too many test cases in the same folder. If we change one of the test cases, we need to rebuild all of it. It will take many times.
2、bazel limit 50 shard_count. it can not run parallel, too many test cases run at slow speed.
3、test cases run in the shard. it is isolated by the sandbox. so it can not suffer from the other test cases. the test will run more stable.

Check List

Tests

  • Unit test
  • Integration test

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 10, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Yisaer
  • tisonkun

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 10, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jun 10, 2022

@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 12, 2022
@hawkingrei hawkingrei changed the title *: enable more flaky test *: enable more flaky test and update bazel config Jun 12, 2022
@hawkingrei hawkingrei requested a review from tisonkun June 12, 2022 10:21
@hawkingrei hawkingrei changed the title *: enable more flaky test and update bazel config *: enable more flaky test , enable more shard_count and update bazel config Jun 12, 2022
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 12, 2022
@hawkingrei hawkingrei force-pushed the enable_flasky_expression branch from 320ac03 to 914b2c9 Compare June 12, 2022 14:41
@hawkingrei hawkingrei changed the title *: enable more flaky test , enable more shard_count and update bazel config *: enable more flaky test, enable more shard_count and update bazel config Jun 13, 2022
@hawkingrei hawkingrei force-pushed the enable_flasky_expression branch 2 times, most recently from abb7fd6 to f26572d Compare June 13, 2022 05:55
ddl/BUILD.bazel Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 13, 2022
@tisonkun
Copy link
Contributor

@hawkingrei stream.go removed without modifying the BUILD.bazel file. It seems not quite smooth from my perspective. Is it possible that we keep sync between the file tree and bazel files? Or we must defer the sync until someone trigger bazel config updates manually?

@hawkingrei
Copy link
Member Author

hawkingrei commented Jun 13, 2022

@hawkingrei stream.go removed without modifying the BUILD.bazel file. It seems not quite smooth from my perspective. Is it possible that we keep sync between the file tree and bazel files? Or we must defer the sync until someone trigger bazel config updates manually?

First, in the cockroach or other open source community, the bazel config is updated by the developers. so I will open it to the developers. But now developers are not similar to bazel. so it needs some time. but I hope it can be implemented as soon as possible.
Second, I think the bazel config is generated by the tools. so we can do it with a robot. it can pass to merge as soon as possible.

@hawkingrei hawkingrei requested a review from XuHuaiyu June 13, 2022 06:40
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei hawkingrei force-pushed the enable_flasky_expression branch from 964f077 to e766a4c Compare June 13, 2022 07:08
@hawkingrei hawkingrei requested a review from wshwsh12 June 13, 2022 08:29
@hawkingrei hawkingrei requested a review from guo-shaoge June 13, 2022 08:29
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 13, 2022
@Yisaer
Copy link
Contributor

Yisaer commented Jun 13, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e766a4c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 13, 2022
@ti-chi-bot ti-chi-bot merged commit d3e9114 into pingcap:master Jun 13, 2022
@hawkingrei hawkingrei deleted the enable_flasky_expression branch June 13, 2022 09:53
@sre-bot
Copy link
Contributor

sre-bot commented Jun 13, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/common-test 🟥 failed 2, success 10, total 12 12 min New failing
idc-jenkins-ci-tidb/integration-common-test 🔴 failed 2, success 9, total 11 21 min Existing failure
idc-jenkins-ci/integration-cdc-test 🟢 all 35 tests passed 29 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 12 min Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 8 min 50 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 8 min 6 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 7 min 48 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 7 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 55 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants