-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: enable more flaky test, enable more shard_count and update bazel config #35300
*: enable more flaky test, enable more shard_count and update bazel config #35300
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/e766a4c8dd26324880dcb1f7ab0118f45ec94242 |
320ac03
to
914b2c9
Compare
abb7fd6
to
f26572d
Compare
@hawkingrei |
First, in the cockroach or other open source community, the bazel config is updated by the developers. so I will open it to the developers. But now developers are not similar to bazel. so it needs some time. but I hope it can be implemented as soon as possible. |
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
964f077
to
e766a4c
Compare
/merge |
This pull request has been accepted and is ready to merge. Commit hash: e766a4c
|
TiDB MergeCI notify🔴 Bad News! New failing [1] after this pr merged.
|
Signed-off-by: Weizhen Wang [email protected]
What problem does this PR solve?
Issue Number: ref #35247
Problem Summary:
What is changed and how it works?
Why are test cases speed up by being splited into subdirectories?
1、execute has too many test cases in the same folder. If we change one of the test cases, we need to rebuild all of it. It will take many times.
2、bazel limit 50 shard_count. it can not run parallel, too many test cases run at slow speed.
3、test cases run in the shard. it is isolated by the sandbox. so it can not suffer from the other test cases. the test will run more stable.
Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.