Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix cte-schema-clone will clone the old hashcode of its column if any (#35415) #35495

Merged
merged 1 commit into from
Jun 19, 2022

Conversation

chrysan
Copy link
Contributor

@chrysan chrysan commented Jun 19, 2022

cherry-pick #35415 to release-6.1-20220619

Thank you for contributing to TiDB!

PR Title Format:

  1. pkg [, pkg2, pkg3]: what's changed
  2. *: what's changed

-->

What problem does this PR solve?

Issue Number: close #35404

Problem Summary:
After #33158, the predicate pushdown for CTE has been supported. While some cases will have some problems when it comes to projection elimination using column's hashcode mapping.

In building dataSource, we clone CTE schema with some newly assigned uniqueID when referring to a CTE. In PR #33158, code as following

for i, col := range lp.schema.Columns {
	lp.cte.ColumnMap[string(col.HashCode(nil))] = prevSchema.Columns[i]
}

here will generate hashcode in columns of the schema of CTE when building CTE itself.
Later when building the main select clause, CTE reference will clone CTE's schema and assign new uniqueIDs, here should clean these hashcodes because they are not valid anymore.(new uniqueID)

What is changed and how it works?

Just a quick test for verity resolveIndices error when select statement with join of CTE reference

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 19, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • time-and-fate
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 19, 2022
@sre-bot sre-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 19, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jun 19, 2022

@chrysan
Copy link
Contributor Author

chrysan commented Jun 19, 2022

/merge

@ti-chi-bot
Copy link
Member

@chrysan: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 19, 2022
@Yisaer
Copy link
Contributor

Yisaer commented Jun 19, 2022

/run-mysql-test

1 similar comment
@chrysan
Copy link
Contributor Author

chrysan commented Jun 19, 2022

/run-mysql-test

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 19, 2022
@chrysan
Copy link
Contributor Author

chrysan commented Jun 19, 2022

/run-mysql-test

@purelind
Copy link
Contributor

/run-mysql-test tidb-test=release-6.1

@chrysan
Copy link
Contributor Author

chrysan commented Jun 19, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ac64367

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 19, 2022
@ti-chi-bot ti-chi-bot merged commit 10f167d into pingcap:release-6.1-20220619 Jun 19, 2022
@purelind purelind added this to the v6.1.1 milestone Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants