Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning: add ReadIndexNotReady as retryable ingest error #36574

Merged
merged 8 commits into from
Jul 26, 2022
Merged

lightning: add ReadIndexNotReady as retryable ingest error #36574

merged 8 commits into from
Jul 26, 2022

Conversation

D3Hunter
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #36566

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@D3Hunter D3Hunter added the component/lightning This issue is related to Lightning of TiDB. label Jul 26, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 26, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • buchuitoudegou
  • gozssky

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 26, 2022
@D3Hunter
Copy link
Contributor Author

/run-integration-br-test

@D3Hunter
Copy link
Contributor Author

/cc @buchuitoudegou @gozssky

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 26, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 26, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 26, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/144f03894263846d173e417c72ddc193061f7ec4

@D3Hunter
Copy link
Contributor Author

/run-integration-br-test

@D3Hunter
Copy link
Contributor Author

/run-check_dev_2
/run-unit-test

@D3Hunter
Copy link
Contributor Author

/run-check_dev_2

@D3Hunter
Copy link
Contributor Author

br ci success, merge

https://ci.pingcap.net/blue/organizations/jenkins/br_ghpr_unit_and_integration_test/detail/br_ghpr_unit_and_integration_test/12584/pipeline

@D3Hunter
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 797f486

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 26, 2022
@ti-chi-bot ti-chi-bot merged commit 0f93fd4 into pingcap:master Jul 26, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 26, 2022
@D3Hunter @ti-srebot
cherry pick pingcap#36574 to release-6.2
97198c1 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Jul 26, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.2 in PR #36597

@sre-bot
Copy link
Contributor

sre-bot commented Jul 26, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [1] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-ddl-test ✅ all 6 tests passed 6 min 56 sec Fixed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 11 tests passed 51 min Existing passed
idc-jenkins-ci/integration-cdc-test 🟢 all 36 tests passed 27 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 12 tests passed 20 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 7 min 35 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 6 min 26 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 13 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 4 min 46 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 14 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@D3Hunter D3Hunter deleted the fix-err branch July 27, 2022 02:19
ti-chi-bot pushed a commit that referenced this pull request Jul 27, 2022
@ti-srebot
lightning: add ReadIndexNotReady as retryable ingest error (#36574) (#…
65f7e2e 
…36597)

close #36566
@D3Hunter D3Hunter added the needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. label Aug 4, 2022
@ti-srebot ti-srebot mentioned this pull request Aug 4, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.1 in PR #36874

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 4, 2022
@D3Hunter @ti-srebot
cherry pick pingcap#36574 to release-6.1
341daa1 
Signed-off-by: ti-srebot <[email protected]>
ti-chi-bot pushed a commit that referenced this pull request Aug 4, 2022
@ti-srebot
lightning: add ReadIndexNotReady as retryable ingest error (#36574) (#…
9dfcd40 
…36874)

close #36566
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sleepymole sleepymole sleepymole approved these changes

@buchuitoudegou buchuitoudegou buchuitoudegou approved these changes

Assignees
No one assigned
Labels
component/lightning This issue is related to Lightning of TiDB. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
6 participants
@D3Hunter @ti-chi-bot @sre-bot @ti-srebot @sleepymole @buchuitoudegou