Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: reduce logs of too many pings #36862

Closed
wants to merge 1 commit into from

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Aug 3, 2022

Signed-off-by: Jack Yu [email protected]

What problem does this PR solve?

Issue Number: close #36861

Problem Summary:
#17885 reduced parts of this kind of logs, it could still be found in v6.1.0. According to grpc/grpc#28830, it seems it is not fixed yet. So disable the external pings for br and lightning.

What is changed and how it works?

Do not use PermitWithoutStream.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 3, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Aug 3, 2022
@jackysp jackysp requested review from 3pointer and YuJuncen August 3, 2022 12:12
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 3, 2022
@bb7133
Copy link
Member

bb7133 commented Aug 4, 2022

LGTM, but PTAL @3pointer

@3pointer
Copy link
Contributor

3pointer commented Aug 9, 2022

br and lightning didn't use grpc to connect TiDB, so I think the error log didn't came from br or lightning

@jackysp
Copy link
Member Author

jackysp commented Aug 15, 2022

br and lightning didn't use grpc to connect TiDB, so I think the error log didn't came from br or lightning

Yes, maybe tiflash, I think. I filed another PR to tiflash pingcap/tiflash#5528.
So another question, is PermitWithoutStream useful for br/lightning? @3pointer

@jackysp jackysp closed this Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

transport: Got too many pings from the client, closing the connection.
5 participants