Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Enable tiflash_fastscan variable and remove fast mode alter statment #37027

Merged
merged 16 commits into from
Aug 29, 2022
Merged

*: Enable tiflash_fastscan variable and remove fast mode alter statment #37027

merged 16 commits into from
Aug 29, 2022

Conversation

hongyunyan
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #35850

Problem Summary:

  1. remove the code related to the ddl 'alter table xx set tiflash mode fast/normal'.
  2. add session/global variable tiflash_fastscan to control whether use fast scan in tiflash.
  3. change the telemetry statistic for fast scan.

[Should merge after the PR(https://github.com/pingcap/tipb/pull/272/files) merged]

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@hongyunyan hongyunyan requested a review from a team as a code owner August 10, 2022 10:27
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 10, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • breezewish
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 10, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Aug 10, 2022

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@hongyunyan hongyunyan mentioned this pull request Aug 10, 2022
Merged
12 tasks
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 10, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 10, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Aug 10, 2022

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 10, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Aug 10, 2022

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 10, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Aug 10, 2022

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@hongyunyan hongyunyan changed the title [DNM][parser,sessionctx, ddl, telemetry] Enable tiflash_fastscan variable and remove fast mode alter statment [DNM] *: Enable tiflash_fastscan variable and remove fast mode alter statment Aug 10, 2022
@hongyunyan
Copy link
Contributor Author

/run-check_title

@hongyunyan
Copy link
Contributor Author

/rebuild

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 12, 2022
@hawkingrei
Copy link
Member

/run-all-tests

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 15, 2022 •
edited by sre-bot
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/81b4d82b1f53bc91991160640ec8ac429fbd9862

@hongyunyan hongyunyan changed the title [DNM] *: Enable tiflash_fastscan variable and remove fast mode alter statment *: Enable tiflash_fastscan variable and remove fast mode alter statment Aug 25, 2022
@hongyunyan
Copy link
Contributor Author

/cc @breezewish

@ti-chi-bot ti-chi-bot requested a review from breezewish August 25, 2022 08:10
breezewish
breezewish reviewed Aug 25, 2022
View reviewed changes
Copy link
Member

@breezewish breezewish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the rest lgtm

sessionctx/variable/tidb_vars.go Show resolved Hide resolved
AstroProfundis
AstroProfundis approved these changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@AstroProfundis AstroProfundis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The telemetry part LGTM

@ti-chi-bot
Copy link
Member

@AstroProfundis: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

The telemetry part LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 25, 2022
@hongyunyan
Copy link
Contributor Author

/cc @xhebox

@ti-chi-bot ti-chi-bot requested a review from xhebox August 25, 2022 08:58
xhebox
xhebox approved these changes Aug 25, 2022
View reviewed changes
telemetry/data_window_test.go Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 25, 2022
@hongyunyan
Copy link
Contributor Author

/cc @pingcap/tidb-configuration-reviewer

@hongyunyan
Copy link
Contributor Author

/run-mysql-test

@xhebox
Copy link
Contributor

xhebox commented Aug 29, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 111b27d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 29, 2022
@hongyunyan
Copy link
Contributor Author

/rebuild

@ti-chi-bot ti-chi-bot merged commit ccd4f34 into pingcap:master Aug 29, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Aug 29, 2022

TiDB MergeCI notify

🔴 Bad News! [2] CI still failing after this pr merged.
These failed integration tests don't seem to be introduced by the current PR.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test 🔴 failed 2, success 15, total 17 16 min Existing failure
idc-jenkins-ci-tidb/common-test 🔴 failed 2, success 9, total 11 14 min Existing failure
idc-jenkins-ci/integration-cdc-test 🟢 all 36 tests passed 32 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 7 min 3 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 6 min 15 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 45 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 13 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 22 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 9 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@solotzg
Copy link
Contributor

solotzg commented Aug 29, 2022

@hongyunyan PTAL https://ci.pingcap.net/blue/organizations/jenkins/tiflash-ghpr-integration-tests/detail/tiflash-ghpr-integration-tests/8414/pipeline

[2022-08-29T09:53:59.517Z]   File: fullstack-test2/ddl/alter_table_tiflash_replica_and_mode.test

[2022-08-29T09:53:59.517Z]   Error line: 35

[2022-08-29T09:53:59.517Z]   Error: alter table test.t set tiflash mode fast

[2022-08-29T09:53:59.517Z]   Result:

[2022-08-29T09:53:59.517Z]     ERROR 1064 (42000) at line 1: You have an error in your SQL syntax; check the manual that corresponds to your TiDB version for the right syntax to use line 1 column 35 near "mode fast"

[2022-08-29T09:53:59.517Z]   Expected:

[2022-08-29T09:53:59.517Z]     <nothing>

@solotzg solotzg mentioned this pull request Aug 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AstroProfundis AstroProfundis AstroProfundis approved these changes

@breezewish breezewish breezewish approved these changes

@xhebox xhebox xhebox approved these changes

@qw4990 qw4990 qw4990 approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@hongyunyan @ti-chi-bot @sre-bot @hawkingrei @xhebox @solotzg @AstroProfundis @breezewish @qw4990