Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: refine github actions and makefile #37235

Merged
merged 12 commits into from
Sep 7, 2022
Merged

*: refine github actions and makefile #37235

merged 12 commits into from
Sep 7, 2022

Conversation

xhebox
Copy link
Contributor

@xhebox xhebox commented Aug 19, 2022 •
edited
Loading

Signed-off-by: xhe [email protected]

What problem does this PR solve?

Issue Number: close None

Problem Summary: Some minor improvement.

What is changed and how it works?

  1. ran yaml linters on all yaml files
  2. check-file-perm is moved into github actions
  3. All misc github actions are combined into one workflow
  4. removed PR labelers, it needs write permissions, but currently TiDB does not have such permission

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@xhebox xhebox added needs-cherry-pick-3.0 needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. skip-issue-check Indicates that a PR no need to check linked issue. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. labels Aug 19, 2022
@xhebox xhebox requested review from hawkingrei and zimulala August 19, 2022 03:43
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 19, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • lcwangchao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 19, 2022
@xhebox xhebox closed this Aug 19, 2022
@xhebox xhebox reopened this Aug 19, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 19, 2022 •
edited by sre-bot
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/f0b045349ddfd51adcfb422d7d9f581b8155a3f1

@xhebox xhebox closed this Aug 19, 2022
@xhebox xhebox reopened this Aug 19, 2022
@xhebox xhebox force-pushed the gha branch 2 times, most recently from acabd70 to b1bdcfd Compare August 19, 2022 04:01
@xhebox xhebox removed the skip-issue-check Indicates that a PR no need to check linked issue. label Aug 19, 2022
@xhebox xhebox marked this pull request as ready for review August 23, 2022 03:16
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 23, 2022
@xhebox xhebox mentioned this pull request Sep 7, 2022
Merged
@xhebox
Copy link
Contributor Author

xhebox commented Sep 7, 2022

/unhold
/merge

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 7, 2022
@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4ca9d48

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 7, 2022
@ti-chi-bot ti-chi-bot merged commit 5f0c580 into pingcap:master Sep 7, 2022
@ti-srebot ti-srebot mentioned this pull request Sep 7, 2022
Closed
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 7, 2022
@xhebox @ti-srebot
cherry pick pingcap#37235 to release-4.0
95e3aa8 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #37695

@ti-srebot ti-srebot mentioned this pull request Sep 7, 2022
Closed
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 7, 2022
@xhebox @ti-srebot
cherry pick pingcap#37235 to release-5.0
cb25236 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #37696

@ti-srebot ti-srebot mentioned this pull request Sep 7, 2022
Closed
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 7, 2022
@xhebox @ti-srebot
cherry pick pingcap#37235 to release-5.1
6fa3995 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #37697

@ti-srebot ti-srebot mentioned this pull request Sep 7, 2022
Closed
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 7, 2022
@xhebox @ti-srebot
cherry pick pingcap#37235 to release-5.2
567e122 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #37698

@ti-srebot ti-srebot mentioned this pull request Sep 7, 2022
Closed
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 7, 2022
@xhebox @ti-srebot
cherry pick pingcap#37235 to release-5.3
b1ac959 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #37699

@ti-srebot ti-srebot mentioned this pull request Sep 7, 2022
Closed
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 7, 2022
@xhebox @ti-srebot
cherry pick pingcap#37235 to release-5.4
e0205a6 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #37700

@ti-srebot ti-srebot mentioned this pull request Sep 7, 2022
Closed
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 7, 2022
@xhebox @ti-srebot
cherry pick pingcap#37235 to release-6.1
db54249 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot
Copy link
Contributor

cherry pick to release-6.1 in PR #37701

@sre-bot
Copy link
Contributor

sre-bot commented Sep 7, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [1] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/common-test 🔴 failed 1, success 10, total 11 12 min Existing failure
idc-jenkins-ci-tidb/integration-common-test ✅ all 17 tests passed 16 min Fixed
idc-jenkins-ci/integration-cdc-test 🟢 all 37 tests passed 23 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 2 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 5 min 42 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 5 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 42 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 43 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 52 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@xhebox xhebox mentioned this pull request Sep 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wuhuizuo wuhuizuo wuhuizuo left review comments

@lcwangchao lcwangchao lcwangchao approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

@VelocityLight VelocityLight VelocityLight approved these changes

@zimulala zimulala Awaiting requested review from zimulala

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@xhebox @ti-chi-bot @lcwangchao @hawkingrei @ti-srebot @sre-bot @wuhuizuo @VelocityLight