Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: Support regexp_like function #37270

Closed
wants to merge 14 commits into from
Closed

expression: Support regexp_like function #37270

wants to merge 14 commits into from

Conversation

xzhangxian1008
Copy link
Contributor

What problem does this PR solve?

Support regexp_like function

Issue Number: ref #23881

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/invalid-title release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 22, 2022
@xzhangxian1008
Copy link
Contributor Author

/cc @windtalker @XuHuaiyu

@xzhangxian1008 xzhangxian1008 changed the title Support regexp_like function expression: Support regexp_like function Aug 22, 2022
@xzhangxian1008
Copy link
Contributor Author

/cc @gengliqi

@ti-chi-bot ti-chi-bot requested a review from gengliqi August 23, 2022 01:51
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 23, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/63dc99e944de52cf32fd9b7fbe381b9c4477f4aa

@xzhangxian1008 xzhangxian1008 deleted the reg_like branch September 19, 2022 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windtalker windtalker Awaiting requested review from windtalker

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

@gengliqi gengliqi Awaiting requested review from gengliqi

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xzhangxian1008 @ti-chi-bot