-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: fix HashJoinExec panic of closed channel (#38576) #38667
executor: fix HashJoinExec panic of closed channel (#38576) #38667
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
1 similar comment
/run-all-tests |
48e6113
to
f0e0367
Compare
/cc @XuHuaiyu |
7f2324a
to
6a92ad4
Compare
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 6a92ad4
|
This is an automated cherry-pick of #38576
What problem does this PR solve?
Issue Number: close #37932
Problem Summary:
What is changed and how it works?
Apply
willOpen
andClose
an operator multiple times. TheHashJoin
belowApply
returns an error in line 171 during Open, thuse.closeCh
is not re-initialized, and thee.closeCh
be closed inHashJoin.Close
is an already closed channel in the last round.To solve it, we set
e.closeCh
tonil
in theClose
function.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.