*: enable the CI test for concurrent ddl #38926

wjhuang2016 · 2022-11-07T04:13:37Z

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: wjhuang2016 <[email protected]>

ti-chi-bot · 2022-11-07T04:13:39Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

hawkingrei
lcwangchao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

ddl/ddl.go

Signed-off-by: wjhuang2016 <[email protected]>

… into fix_concurrent_ddl_test

wjhuang2016 · 2022-11-07T07:02:18Z

/merge

ti-chi-bot · 2022-11-07T07:02:21Z

This pull request has been accepted and is ready to merge.

Commit hash: 5037d39

hawkingrei · 2022-11-07T07:37:52Z

        	Error:      	Expected nil, but got: "invalid memory address or nil pointer dereference"
        	Test:       	TestBatchInsertWithOnDuplicate
        	Messages:   	goroutine 289933 [running]:
        	            	github.com/pingcap/tidb/testkit.GetStack(...)
        	            		testkit/asynctestkit.go:76
        	            	github.com/pingcap/tidb/testkit.(*AsyncTestKit).ConcurrentRun.func1.1()
        	            		testkit/asynctestkit.go:107 +0x7b
        	            	panic({0x489e420, 0x7485a00})
        	            		GOROOT/src/runtime/panic.go:884 +0x212
        	            	github.com/pingcap/tidb/executor.(*ExecStmt).Exec.func1()
        	            		executor/adapter.go:438 +0x417
        	            	panic({0x489e420, 0x7485a00})
        	            		GOROOT/src/runtime/panic.go:884 +0x212
        	            	github.com/pingcap/tidb/infoschema.(*SessionExtendedInfoSchema).TableByID(0xc01b335260, 0x2?)
        	            		infoschema/infoschema.go:662 +0xe3
        	            	github.com/pingcap/tidb/session.addTableNameInTableIDField({0x470d060?, 0xc0254d9f10?}, {0x56e1510, 0xc01b335260})
        	            		session/session.go:1059 +0x116
        	            	github.com/pingcap/tidb/session.(*session).tryReplaceWriteConflictError(0xc0095db400?, {0x5683860, 0xc00daa4ea0})
        	            		session/session.go:1032 +0x11a
        	            	github.com/pingcap/tidb/session.(*session).doCommitWithRetry(0xc0095db400, {0x56abe70, 0xc0286493b0})
        	            		session/session.go:967 +0x335
        	            	github.com/pingcap/tidb/session.(*session).CommitTxn(0xc0095db400, {0x56abe70, 0xc028648810})
        	            		session/session.go:1094 +0x258
        	            	github.com/pingcap/tidb/sessiontxn/internal.CommitBeforeEnterNewTxn({0x56abe70, 0xc028648810}, {0x571c108, 0xc0095db400})
        	            		sessiontxn/internal/txn.go:51 +0x113
        	            	github.com/pingcap/tidb/sessiontxn/isolation.(*baseTxnContextProvider).OnInitialize(0xc00a50e3f0, {0x56abe70?, 0xc028648810?}, 0x0)
        	            		sessiontxn/isolation/base.go:83 +0x26d
        	            	github.com/pingcap/tidb/session.(*txnManager).EnterNewTxn(0xc00a50e3c0, {0x56abe70, 0xc028648810}, 0xc0093d5200)
        	            		session/txnmanager.go:147 +0x78
        	            	github.com/pingcap/tidb/sessiontxn.NewTxn({0x56abe70, 0xc028648810}, {0x571c108?, 0xc0095db400?})
        	            		sessiontxn/interface.go:200 +0x91
        	            	github.com/pingcap/tidb/sessiontxn.NewTxnInStmt({0x56abe70, 0xc028648810}, {0x571c108, 0xc0095db400})
        	            		sessiontxn/interface.go:209 +0x3b
        	            	github.com/pingcap/tidb/executor.(*InsertValues).doBatchInsert(0xc006a44a80, {0x56abe70, 0xc028648810})
        	            		executor/insert_common.go:541 +0x138
        	            	github.com/pingcap/tidb/executor.insertRows({0x56abe70, 0xc028648810}, {0x5690de0, 0xc00a615c20})
        	            		executor/insert_common.go:272 +0x5fa
        	            	github.com/pingcap/tidb/executor.(*InsertExec).Next(0xc00a615c20, {0x56abe70, 0xc028648750}, 0xc0286485d0?)
        	            		executor/insert.go:313 +0xf0
        	            	github.com/pingcap/tidb/executor.Next({0x56abe70, 0xc028648750}, {0x56b0320, 0xc00a615c20}, 0xc00a60fe50)
        	            		executor/executor.go:327 +0x55f
        	            	github.com/pingcap/tidb/executor.(*ExecStmt).next(0xc00a369ef0, {0x56abe70, 0xc028648750}, {0x56b0320, 0xc00a615c20}, 0x0?)
        	            		executor/adapter.go:1118 +0x7e
        	            	github.com/pingcap/tidb/executor.(*ExecStmt).handleNoDelayExecutor(0xc00a369ef0, {0x56abe70, 0xc028648750}, {0x56b0320?, 0xc00a615c20})
        	            		executor/adapter.go:891 +0x611
        	            	github.com/pingcap/tidb/executor.(*ExecStmt).handleNoDelay(0xc00a369ef0, {0x56abe70, 0xc028648750}, {0x56b0320?, 0xc00a615c20?}, 0x0)
        	            		executor/adapter.go:739 +0x29d
        	            	github.com/pingcap/tidb/executor.(*ExecStmt).Exec(0xc00a369ef0, {0x56abe70, 0xc028648750})
        	            		executor/adapter.go:544 +0xf78
        	            	github.com/pingcap/tidb/session.runStmt({0x56abe70, 0xc01b800ea0}, 0xc0095db400, {0x56bd380, 0xc00a369ef0?})
        	            		session/session.go:2341 +0x6c9
        	            	github.com/pingcap/tidb/session.(*session).ExecuteStmt(0xc0095db400, {0x56abe70, 0xc01b800ea0}, {0x56c4050?, 0xc00a680c80?})
        	            		session/session.go:2205 +0xcf6
        	            	github.com/pingcap/tidb/session.(*session).ExecutePreparedStmt(0xc0095db400, {0x56abe70, 0xc01b800ea0}, 0x1, {0xc00a69f180, 0x7, 0x7})
        	            		session/session.go:2511 +0x1a9
        	            	github.com/pingcap/tidb/testkit.(*AsyncTestKit).Exec(0xc01997dce0, {0x56abe70, 0xc01b800ea0}, {0x4f15cdc, 0x48}, {0xc00aaa2310, 0x7, 0x7})
        	            		testkit/asynctestkit.go:164 +0x1c3
        	            	github.com/pingcap/tidb/executor_test.TestBatchInsertWithOnDuplicate.func2({0x56abe70, 0xc01b800ea0}, 0xc009db6798?, {0xc015d0e210, 0x1, 0xc036b10780?})
        	            		executor/write_concurrent_test.go:54 +0xbf
        	            	github.com/pingcap/tidb/testkit.(*AsyncTestKit).ConcurrentRun.func1()
        	            		testkit/asynctestkit.go:112 +0x12a
        	            	created by github.com/pingcap/tidb/testkit.(*AsyncTestKit).ConcurrentRun
        	            		testkit/asynctestkit.go:104 +0xc7

hawkingrei · 2022-11-07T07:38:01Z

/hold

hawkingrei · 2022-11-07T15:02:17Z

/unhold

hawkingrei · 2022-11-07T15:15:27Z

/run-check_dev_2

hawkingrei · 2022-11-07T16:05:21Z

/hold

Signed-off-by: wjhuang2016 <[email protected]>

… into fix_concurrent_ddl_test

hawkingrei · 2022-11-09T08:03:26Z

/run-unit-test

Signed-off-by: wjhuang2016 <[email protected]>

hawkingrei · 2022-11-09T16:38:21Z

/unhold

hawkingrei · 2022-11-09T16:38:30Z

/merge

ti-chi-bot · 2022-11-09T16:38:33Z

This pull request has been accepted and is ready to merge.

Commit hash: 82c8073

sre-bot · 2022-11-09T17:52:48Z

TiDB MergeCI notify

✅ Well Done! New fixed [1] after this pr merged.

CI Name	Result	Duration	Compare with Parent commit
idc-jenkins-ci-tidb/integration-ddl-test	🔴 failed 1, success 5, total 6	43 min	Existing failure
idc-jenkins-ci-tidb/mybatis-test	🔴 failed 1, success 0, total 1	11 min	Existing failure
idc-jenkins-ci/integration-cdc-test	✅ all 39 tests passed	20 min	Fixed
idc-jenkins-ci-tidb/integration-common-test	🟢 all 17 tests passed	15 min	Existing passed
idc-jenkins-ci-tidb/common-test	🟢 all 11 tests passed	9 min 30 sec	Existing passed
idc-jenkins-ci-tidb/tics-test	🟢 all 1 tests passed	7 min 20 sec	Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2	🟢 all 28 tests passed	4 min 20 sec	Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1	🟢 all 26 tests passed	3 min 58 sec	Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test	🟢 all 1 tests passed	2 min 48 sec	Existing passed
idc-jenkins-ci-tidb/plugin-test	🟢 build success, plugin test success	4min	Existing passed

wjhuang2016 added 2 commits November 7, 2022 12:08

try

4d9a71c

Signed-off-by: wjhuang2016 <[email protected]>

recover

06225ca

Signed-off-by: wjhuang2016 <[email protected]>

ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 7, 2022

wjhuang2016 added the skip-issue-check Indicates that a PR no need to check linked issue. label Nov 7, 2022

lcwangchao approved these changes Nov 7, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 7, 2022

hawkingrei approved these changes Nov 7, 2022

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 7, 2022

Merge branch 'master' into fix_concurrent_ddl_test

1f19e3c

hawkingrei reviewed Nov 7, 2022

View reviewed changes

ddl/ddl.go Outdated Show resolved Hide resolved

wjhuang2016 added 2 commits November 7, 2022 14:57

fix

7fe6392

Signed-off-by: wjhuang2016 <[email protected]>

Merge branch 'fix_concurrent_ddl_test' of github.com:wjhuang2016/tidb…

5037d39

… into fix_concurrent_ddl_test

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 7, 2022

ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2022

lcwangchao mentioned this pull request Nov 7, 2022

*: fix panic when reusing OptimisticTxnContextProvider #38952

Merged

1 task

ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2022

Merge branch 'master' into fix_concurrent_ddl_test

0442285

ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2022

wjhuang2016 and others added 2 commits November 8, 2022 15:41

Merge branch 'master' into fix_concurrent_ddl_test

96f3eb0

Merge branch 'master' into fix_concurrent_ddl_test

f999a54

hawkingrei and others added 3 commits November 9, 2022 12:30

Merge branch 'master' into fix_concurrent_ddl_test

0962264

fix test

1e1038e

Signed-off-by: wjhuang2016 <[email protected]>

Merge branch 'fix_concurrent_ddl_test' of github.com:wjhuang2016/tidb…

c8da03f

… into fix_concurrent_ddl_test

ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Nov 9, 2022

wjhuang2016 added 2 commits November 9, 2022 18:28

fix

8c8d680

Signed-off-by: wjhuang2016 <[email protected]>

fix test

82c8073

Signed-off-by: wjhuang2016 <[email protected]>

ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 9, 2022

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 9, 2022

Merge branch 'master' into fix_concurrent_ddl_test

bb0609a

ti-chi-bot merged commit 9761e67 into pingcap:master Nov 9, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

*: enable the CI test for concurrent ddl #38926

*: enable the CI test for concurrent ddl #38926

wjhuang2016 commented Nov 7, 2022 •

edited

Loading

ti-chi-bot commented Nov 7, 2022 •

edited

Loading

wjhuang2016 commented Nov 7, 2022

ti-chi-bot commented Nov 7, 2022

hawkingrei commented Nov 7, 2022

hawkingrei commented Nov 7, 2022

hawkingrei commented Nov 7, 2022

hawkingrei commented Nov 7, 2022

hawkingrei commented Nov 7, 2022

hawkingrei commented Nov 9, 2022

hawkingrei commented Nov 9, 2022

hawkingrei commented Nov 9, 2022

ti-chi-bot commented Nov 9, 2022

sre-bot commented Nov 9, 2022

*: enable the CI test for concurrent ddl #38926

*: enable the CI test for concurrent ddl #38926

Conversation

wjhuang2016 commented Nov 7, 2022 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

ti-chi-bot commented Nov 7, 2022 • edited Loading

wjhuang2016 commented Nov 7, 2022

ti-chi-bot commented Nov 7, 2022

hawkingrei commented Nov 7, 2022

hawkingrei commented Nov 7, 2022

hawkingrei commented Nov 7, 2022

hawkingrei commented Nov 7, 2022

hawkingrei commented Nov 7, 2022

hawkingrei commented Nov 9, 2022

hawkingrei commented Nov 9, 2022

hawkingrei commented Nov 9, 2022

ti-chi-bot commented Nov 9, 2022

sre-bot commented Nov 9, 2022

TiDB MergeCI notify

wjhuang2016 commented Nov 7, 2022 •

edited

Loading

ti-chi-bot commented Nov 7, 2022 •

edited

Loading