Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log-backup: use the span tree(instead of the naïve algorithm) to calculate the checkpoint #39122

Merged
merged 17 commits into from
Nov 29, 2022
Merged

log-backup: use the span tree(instead of the naïve algorithm) to calculate the checkpoint #39122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
77211fe
use span (tree?) to replace checkpoint heap
YuJuncen Nov 2, 2022
f6b3624
adapt ranges
YuJuncen Nov 11, 2022
3db857c
remove unrelatived code
YuJuncen Nov 11, 2022
0b00cc8
make CI happy
YuJuncen Nov 14, 2022
b3008d2
fixed a bug over subranges
YuJuncen Nov 14, 2022
e592b7e
try make linter happy
YuJuncen Nov 14, 2022
bf27ca8
Merge branch 'master' into span-tree
YuJuncen Nov 15, 2022
a7772ad
updated bazel
YuJuncen Nov 15, 2022
7613d04
Merge branch 'span-tree' of https://github.com/YuJuncen/tidb into spa…
YuJuncen Nov 15, 2022
585d2e1
fix bugs
YuJuncen Nov 25, 2022
fd4918c
address comments
YuJuncen Nov 28, 2022
102941e
check length before checking
YuJuncen Nov 28, 2022
7ba6318
Merge branch 'master' into span-tree
YuJuncen Nov 29, 2022
3e619d7
Merge branch 'master' into span-tree
ti-chi-bot Nov 29, 2022
79cfe5e
Merge branch 'master' into span-tree
ti-chi-bot Nov 29, 2022
0aec2af
Merge branch 'master' into span-tree
ti-chi-bot Nov 29, 2022
64c307b
Merge branch 'master' into span-tree
ti-chi-bot Nov 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions br/pkg/logutil/logging.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,3 +306,13 @@ func (rng StringifyRange) String() string {
sb.WriteString(")")
return sb.String()
}

// StringifyMany returns an array marshaler for a slice of stringers.
func StringifyMany[T fmt.Stringer](items []T) zapcore.ArrayMarshaler {
return zapcore.ArrayMarshalerFunc(func(ae zapcore.ArrayEncoder) error {
for _, item := range items {
ae.AppendString(item.String())
}
return nil
})
}
6 changes: 2 additions & 4 deletions br/pkg/streamhelper/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ go_library(
"models.go",
"prefix_scanner.go",
"regioniter.go",
"tsheap.go",
],
importpath = "github.com/pingcap/tidb/br/pkg/streamhelper",
visibility = ["//visibility:public"],
Expand All @@ -21,6 +20,7 @@ go_library(
"//br/pkg/logutil",
"//br/pkg/redact",
"//br/pkg/streamhelper/config",
"//br/pkg/streamhelper/spans",
"//br/pkg/utils",
"//config",
"//kv",
Expand All @@ -29,7 +29,6 @@ go_library(
"//util/mathutil",
"@com_github_gogo_protobuf//proto",
"@com_github_golang_protobuf//proto",
"@com_github_google_btree//:btree",
"@com_github_google_uuid//:uuid",
"@com_github_pingcap_errors//:errors",
"@com_github_pingcap_kvproto//pkg/brpb",
Expand All @@ -44,7 +43,6 @@ go_library(
"@org_golang_google_grpc//keepalive",
"@org_golang_x_sync//errgroup",
"@org_uber_go_zap//:zap",
"@org_uber_go_zap//zapcore",
],
)

Expand All @@ -56,7 +54,6 @@ go_test(
"basic_lib_for_test.go",
"integration_test.go",
"regioniter_test.go",
"tsheap_test.go",
],
flaky = True,
race = "on",
Expand All @@ -68,6 +65,7 @@ go_test(
"//br/pkg/redact",
"//br/pkg/storage",
"//br/pkg/streamhelper/config",
"//br/pkg/streamhelper/spans",
"//br/pkg/utils",
"//kv",
"//tablecodec",
Expand Down
Loading