Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add a memdb memory tracker #39372

Merged
merged 11 commits into from
Nov 25, 2022
Merged

*: add a memdb memory tracker #39372

merged 11 commits into from
Nov 25, 2022

Conversation

ekexium
Copy link
Member

@ekexium ekexium commented Nov 24, 2022

What problem does this PR solve?

Issue Number: ref #35203

Problem Summary:

This is a duplicate of #35225 to bypass CLA check failure because of the change of my email address.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

* add a memdb memory tracker

Signed-off-by: ekexium <[email protected]>

* update deps

* fix test

Signed-off-by: ekexium <[email protected]>

* remove the fake tracking of memdb in insert

Signed-off-by: ekexium <[email protected]>

* simplify the signature

Signed-off-by: ekexium <[email protected]>

* fix conflict

Signed-off-by: ekexium <[email protected]>

* fix conflict

Signed-off-by: ekexium <[email protected]>

* fix: move the tracker out of TxnInfo

Signed-off-by: ekexium <[email protected]>

* refactor: use switch-default

Signed-off-by: ekexium <[email protected]>

* fix: only reset session tracker when detach SQLText tracker

Signed-off-by: ekexium <[email protected]>

* test: fix TestTiDBTrx

Signed-off-by: ekexium <[email protected]>

* update client-go

Signed-off-by: ekexium <[email protected]>

Signed-off-by: ekexium <[email protected]>
Signed-off-by: ekexium <[email protected]>
Co-authored-by: ekexium <[email protected]>
Co-authored-by: Weizhen Wang <[email protected]>
Co-authored-by: Ti Chi Robot <[email protected]>
@ekexium ekexium requested a review from a team as a code owner November 24, 2022 10:06
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 24, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • XuHuaiyu
  • wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 24, 2022
@ekexium ekexium requested review from XuHuaiyu and wshwsh12 November 24, 2022 10:06
@ekexium ekexium mentioned this pull request Nov 24, 2022
12 tasks
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 25, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 25, 2022
@XuHuaiyu
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: bfc880b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 25, 2022
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 25, 2022
@ti-chi-bot ti-chi-bot removed status/can-merge Indicates a PR has been approved by a committer. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 25, 2022
Signed-off-by: ekexium <[email protected]>
@XuHuaiyu
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: eddfc6b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 25, 2022
@ti-chi-bot ti-chi-bot merged commit 15b523c into pingcap:master Nov 25, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Nov 25, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [1] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/mybatis-test ✅ all 1 tests passed 6 min 41 sec Fixed
idc-jenkins-ci/integration-cdc-test 🟢 all 39 tests passed 21 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 14 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 10 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 30 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 52 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 5 min 3 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 33 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 21 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants