-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
session: remove useless parser object in SessionHandle of bindinfo package #39439
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-mysql-test |
This reverts commit 68eecc2.
/run-all-tests |
/run-mysql-test |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: a8dfda7
|
/run-mysql-test tidb-test=pr/2026 |
/run-mysql-test tidb-test=pr/2026 |
TiDB MergeCI notify🔴 Bad News! [2] CI still failing after this pr merged.
|
As the title said.
What problem does this PR solve?
remove useless parser object in SessionHandle. If need to use parser object in bindinfo in the future, we should use sessionPool to get parser object than create a new one. just like what
tidb/session/session.go
Line 1547 in f8a6bde
What is changed and how it works?
Check List
Tests
just delete useless code, use
make
to check.Side effects
no
Release note