executor: fix data race in the slowQueryRuntimeStats

[hawkingrei]

Signed-off-by: Weizhen Wang [email protected]

What problem does this PR solve?

Issue Number: close #39631

Problem Summary:

What is changed and how it works?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• crazycs520
• wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[hawkingrei]

/run-check_dev

[hawkingrei]

/run-check_dev

[crazycs520]

You can fix this by following change:

diff --git a/executor/memtable_reader.go b/executor/memtable_reader.go
index dc215e71fe..4d6e5112bf 100644
--- a/executor/memtable_reader.go
+++ b/executor/memtable_reader.go
@@ -138,7 +138,7 @@ func (e *MemTableReaderExec) Next(ctx context.Context, req *chunk.Chunk) error {
 // Close implements the Executor Close interface.
 func (e *MemTableReaderExec) Close() error {
        if stats := e.retriever.getRuntimeStats(); stats != nil && e.runtimeStats != nil {
-               e.ctx.GetSessionVars().StmtCtx.RuntimeStatsColl.RegisterStats(e.id, stats)
+               defer e.ctx.GetSessionVars().StmtCtx.RuntimeStatsColl.RegisterStats(e.id, stats)
        }
        return e.retriever.close()
 }

[hawkingrei]

You can fix this by following change:

diff --git a/executor/memtable_reader.go b/executor/memtable_reader.go
index dc215e71fe..4d6e5112bf 100644
--- a/executor/memtable_reader.go
+++ b/executor/memtable_reader.go
@@ -138,7 +138,7 @@ func (e *MemTableReaderExec) Next(ctx context.Context, req *chunk.Chunk) error {
 // Close implements the Executor Close interface.
 func (e *MemTableReaderExec) Close() error {
        if stats := e.retriever.getRuntimeStats(); stats != nil && e.runtimeStats != nil {
-               e.ctx.GetSessionVars().StmtCtx.RuntimeStatsColl.RegisterStats(e.id, stats)
+               defer e.ctx.GetSessionVars().StmtCtx.RuntimeStatsColl.RegisterStats(e.id, stats)
        }
        return e.retriever.close()
 }

Done

[wshwsh12]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 44a45cd

[sre-bot]

TiDB MergeCI notify

✅ Well Done! New fixed [1] after this pr merged.

CI Name	Result	Duration	Compare with Parent commit
idc-jenkins-ci/integration-cdc-test	🔴 failed 1, success 39, total 40	20 min	Existing failure
idc-jenkins-ci-tidb/integration-ddl-test	🔴 failed 1, success 5, total 6	5 min 10 sec	Existing failure
idc-jenkins-ci-tidb/sqllogic-test-2	✅ all 28 tests passed	5 min 53 sec	Fixed
idc-jenkins-ci-tidb/integration-common-test	🟢 all 17 tests passed	16 min	Existing passed
idc-jenkins-ci-tidb/common-test	🟢 all 11 tests passed	10 min	Existing passed
idc-jenkins-ci-tidb/tics-test	🟢 all 1 tests passed	6 min 2 sec	Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1	🟢 all 26 tests passed	5 min 41 sec	Existing passed
idc-jenkins-ci-tidb/mybatis-test	🟢 all 1 tests passed	3 min 59 sec	Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test	🟢 all 1 tests passed	3 min 50 sec	Existing passed
idc-jenkins-ci-tidb/plugin-test	🟢 build success, plugin test success	4min	Existing passed