-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ttl, variables: add system variables for ttl job schedule (#39727) #39869
ttl, variables: add system variables for ttl job schedule (#39727) #39869
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
f0bae26
to
73e519b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-check_dev_2 |
/run-build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-unit-test |
Oops. To pass the unit-test, it requires #39767 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 73e519b
|
@ti-chi-bot: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This is an automated cherry-pick of #39727
What problem does this PR solve?
Issue Number: close #39725
Problem Summary:
Add the following system variable for ttl job schedule:
It also removes the
TTLFeatureGate
What is changed and how it works?
These global variables (except worker counts) are all tracked by an atomic variable, and set/get through the hook. The scan/delete worker count are set/get through scaling the workers in the ttl job manager.
This PR is based on #39472
Check List
Tests
Release note