Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: unify the behavior of prepare/execute limit to mysql #40360

Merged
merged 34 commits into from
Jan 10, 2023
Merged
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
0557606
commit
fzzf678 Jan 6, 2023
5d45069
Merge branch 'master' into planCache_limit_behaviour
fzzf678 Jan 6, 2023
28dd3f6
Merge branch 'master' into planCache_limit_behaviour
fzzf678 Jan 6, 2023
a723944
Update logical_plan_builder.go
fzzf678 Jan 6, 2023
349d284
Merge branch 'planCache_limit_behaviour' of https://github.com/fzzf67…
fzzf678 Jan 6, 2023
d1b95cf
Update logical_plan_builder.go
fzzf678 Jan 6, 2023
463b85f
Update plan_cache_test.go
fzzf678 Jan 6, 2023
ed925f9
fix ut
fzzf678 Jan 6, 2023
47cfbfa
Merge branch 'master' into planCache_limit_behaviour
fzzf678 Jan 6, 2023
39b8b7b
Merge branch 'master' into planCache_limit_behaviour
fzzf678 Jan 9, 2023
5c383c8
Update logical_plan_builder.go
fzzf678 Jan 9, 2023
26d1455
Merge branch 'planCache_limit_behaviour' of https://github.com/fzzf67…
fzzf678 Jan 9, 2023
b7c7c59
Update logical_plan_builder.go
fzzf678 Jan 9, 2023
87ad598
rename
fzzf678 Jan 9, 2023
6094e46
reanme
fzzf678 Jan 9, 2023
ffc51a3
Merge branch 'master' into planCache_limit_behaviour
fzzf678 Jan 9, 2023
7c3a2cc
test
fzzf678 Jan 9, 2023
e44d8ca
Update prepared_test.go
fzzf678 Jan 9, 2023
49855b0
Update logical_plan_builder.go
fzzf678 Jan 9, 2023
850b34a
amazing
fzzf678 Jan 9, 2023
253f14a
Update plan_cache_test.go
fzzf678 Jan 9, 2023
eddee4f
Update plan_cache_test.go
fzzf678 Jan 9, 2023
f9e204f
Update plan_cache_test.go
fzzf678 Jan 9, 2023
924cd7d
Merge branch 'master' into planCache_limit_behaviour
fzzf678 Jan 9, 2023
00e2abd
Update plan_cache_test.go
fzzf678 Jan 9, 2023
f9b93a8
Merge branch 'planCache_limit_behaviour' of https://github.com/fzzf67…
fzzf678 Jan 9, 2023
f774bd6
Update plan_cache_test.go
fzzf678 Jan 9, 2023
55bac3b
Update plan_cache_test.go
fzzf678 Jan 9, 2023
858d59f
Update plan_cache_test.go
fzzf678 Jan 9, 2023
d11cafe
Update plan_cache_test.go
fzzf678 Jan 9, 2023
32e4337
Update plan_cache_test.go
fzzf678 Jan 9, 2023
68546d5
test
fzzf678 Jan 9, 2023
d269e8c
Update prepared_test.go
fzzf678 Jan 9, 2023
d556fc8
WhyThisWorks
fzzf678 Jan 9, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update plan_cache_test.go
  • Loading branch information
fzzf678 committed Jan 9, 2023
commit 55bac3bedcc0503fb5f1980425f1615b896bbf14
5 changes: 1 addition & 4 deletions planner/core/plan_cache_test.go
Original file line number Diff line number Diff line change
@@ -467,10 +467,7 @@ func TestUnsupportedLimitCase(t *testing.T) {
tk.MustExec("create table t(a int, key(a))")
tk.MustExec("prepare stmt from 'select 1 limit ?'")

tk.MustExec("set @a = 1.2")
_, err := tk.Exec("execute stmt using @a")
require.True(t, plannercore.ErrWrongArguments.Equal(err))

//tk.MustExec("set @a = 1.2")
//tk.MustGetErrMsg("execute stmt using @a", "[planner:1210]Incorrect arguments to LIMIT")
//tk.MustExec("set @a = 1.")
//tk.MustGetErrMsg("execute stmt using @a", "[planner:1210]Incorrect arguments to LIMIT")