-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
log-backup: should set default value gc.ratio-threshold
after pitr finished (#40141)
#40366
log-backup: should set default value gc.ratio-threshold
after pitr finished (#40141)
#40366
Conversation
Signed-off-by: joccau <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 372284e
|
/test unit-test |
This is an automated cherry-pick of #40141
Signed-off-by: joccau [email protected]
What problem does this PR solve?
Issue Number: close #40185
Problem Summary:
If the process of running PITR is killed first, and run PITR again and is successfully, but the
show config where name = 'gc.ratio-threshold' and type = 'tikv'
is-1
What is changed and how it works?
Set 1.1 (the default value) to
gc.ratio-threshold
if find the old value is negative after PITR.Check List
Tests
Manual test
show config where name = 'gc.ratio-threshold' and type = 'tikv'
is1.1
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.