Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Reorganize partition feature branch updated with master. #40917

Closed
Closed
Changes from 1 commit
Commits
Show all changes
879 commits
Select commit Hold shift + click to select a range
8a4b31a
store/copr: don't reset concurrency of analyze req to 2 (#40168)
xuyifangreeneyes Dec 26, 2022
2f6401a
build(deps): bump golang.org/x/oauth2 from 0.2.0 to 0.3.0 (#40140)
dependabot[bot] Dec 26, 2022
fc241b2
domain: revise plan replayer process log (#40126)
Yisaer Dec 26, 2022
f9d4a54
expression: impl cast as array function (#40076)
xiongjiwei Dec 26, 2022
fc714e2
session: fix tidb_enable_gc_aware_memory_track after upgrade (#40173)
chrysan Dec 26, 2022
79ab2b9
restore: Fix prealloc (#40176)
YuJuncen Dec 26, 2022
ab01065
metrics: remove Keep Alive OPM metric (#40142)
CbcWestwolf Dec 27, 2022
3c8f11d
util: fix data race in the cpu test (#40154)
hawkingrei Dec 27, 2022
20bb046
executor: move some test into writetest (#40097)
hawkingrei Dec 27, 2022
a94cde3
planner: fix an unstable explain test case (#40199)
qw4990 Dec 27, 2022
83d275c
ddl: Refine the error message to compatible with MySQL when drop a pa…
jiyfhust Dec 27, 2022
afbef28
executor: TiFlash supports stale read (#40048)
Dec 27, 2022
32f9604
ddl: ignore internal http client goroutine in leak tests (#40190)
tangenta Dec 27, 2022
bddfc62
ddl: add more foreign key test case (#40052)
crazycs520 Dec 28, 2022
11f5c17
*: add support for -initialize-sql-file on first bootstrap (#35625)
morgo Dec 28, 2022
b268c65
*: fix PointGet will return an stale value when `tidb_enable_plan_rep…
lcwangchao Dec 28, 2022
f9af75f
planner: support converting `json_member_of` to IndexMerge to access …
qw4990 Dec 28, 2022
b196756
planner: record reasons when skipping Plan Cache (#40210)
qw4990 Dec 28, 2022
869b21d
session: Do not run telemetry loops when it's disabled in config (#40…
sunxiaoguang Dec 28, 2022
667bc4c
docs/design: REORGANIZE PARTITION design (#38246)
mjonss Dec 28, 2022
c8124a0
ddl: Disable RENAME COLUMN for partitioning columns | tidb-test=pr/20…
mjonss Dec 29, 2022
92a936e
dumpling: add foreign key e2e test (#40133)
crazycs520 Dec 29, 2022
cf34941
ttl: make the TTL compatible with dumpling, lightning and BR (#40216)
lcwangchao Dec 29, 2022
1a7b395
ttl, domain: setup a customized session pool with stats collector (#4…
YangKeao Dec 29, 2022
6dff69f
ddl: Support flashback cluster with ddl history (#40209)
Defined2014 Dec 29, 2022
875c002
lightning: add foreign key test (#40103)
crazycs520 Dec 29, 2022
b94042c
planner: refine planner code for disaggregated tiflash mode (#39813)
guo-shaoge Dec 29, 2022
ea29db5
docs: update tidb roadmap based on v6.5 (#40170)
ran-huang Dec 29, 2022
ffaf2ac
planner: remove the unnecessary skip-plan-cache flag in StmtCtx (#40235)
qw4990 Dec 30, 2022
25dd54f
ttl: fix change status sql argument (#40234)
YangKeao Dec 30, 2022
72f52f3
planner: update the plan cache strategy when expressions with paramet…
qw4990 Dec 30, 2022
0134d0b
go.mod: upgrade badger to 20221229114011 (#40236)
YangKeao Dec 30, 2022
d3b952a
executor: write multi-valued index (#40172)
xiongjiwei Dec 30, 2022
8e80e7c
expression: implement `unhex` function pushdown to tiflash (#39898)
b41sh Dec 30, 2022
b97f60d
planner: remove the unnecessary skip-plan-cache flag in StmtCtx (#40246)
qw4990 Dec 30, 2022
1b8a233
restore: set config value to default when failed to get config from t…
YuJuncen Dec 30, 2022
6131e3f
ddl: check default value again in updateColumnDefaultValue (#40230)
wjhuang2016 Dec 30, 2022
91adaaf
docs: update roadmap (#40244)
ran-huang Dec 30, 2022
f7de8be
*: remove the support of the old ddl framework (#39684)
wjhuang2016 Dec 30, 2022
47080d9
lightning: check peers write stall when switch-mode is disabled (#40228)
lance6716 Dec 30, 2022
702a559
ddl, parser: make generated column and expression index same as MySQL…
Defined2014 Dec 30, 2022
25a2479
session: make plan replayer capture support prepared stmt (#40167)
Yisaer Jan 3, 2023
67a952a
expression: implement `regexp_replace` function pushdown (#40267)
xzhangxian1008 Jan 3, 2023
1bf230a
planner: supply more test for binding from history (#40242)
fzzf678 Jan 3, 2023
be8caa6
ttl: disable ttl job when recover/flashback table/database/cluster (#…
lcwangchao Jan 3, 2023
494672c
admin: impl admin check index for mv index (#40270)
xiongjiwei Jan 3, 2023
5327d07
planner: refactor plan-cache UseCache flag (#40256)
qw4990 Jan 3, 2023
9aaa93e
test: fix data race in cast as array (#40277)
xiongjiwei Jan 3, 2023
4f1adb9
planner: support converting `json_overlaps/contains` to IndexMerge to…
qw4990 Jan 3, 2023
1f344ba
autoid_service: add unit test for the package (#40193)
tiancaiamao Jan 3, 2023
3ccff46
executor: special handling is required when an "auto id out of range"…
Dousir9 Jan 3, 2023
3e65e9b
util: gorotinue pool (#39872)
hawkingrei Jan 4, 2023
f483b39
metrics: add metrics for plan replayer and historical stats (#40271)
Yisaer Jan 4, 2023
3e6499b
sysvar: fix circular dependency in rebuildSysVarCache leading to dead…
CbcWestwolf Jan 4, 2023
e95881f
ddl: fix flaky test TestGlobalVariablesOnFlashback (#40291)
Defined2014 Jan 4, 2023
62a7133
server, tidb-server: kill auto analyze when gracefully shutting down …
xuyifangreeneyes Jan 4, 2023
7fafb6d
planner: better coordination between the ignore_plan_cache() binding …
qw4990 Jan 4, 2023
ccee532
store/copr: fix build batchCop in disaggregated tiflash mode (#40008)
guo-shaoge Jan 4, 2023
73c8cc7
ddl: persist index info after changing backfill state (#40229)
tangenta Jan 4, 2023
e7e7935
doc: update flashback doc (#40031)
Defined2014 Jan 4, 2023
cb5affb
ddl, parser: Implement the write-reorg state split task related funct…
zimulala Jan 4, 2023
95f0dc5
planner: support pushing down predicates to memory tables in prepared…
djshow832 Jan 4, 2023
6ae151a
planner: open the partial order prop push down for LIST PARTITION (#4…
winoros Jan 4, 2023
00604eb
br: fix bootstrap domain (#40307)
wjhuang2016 Jan 4, 2023
bf2cc45
br: add errch buf for checkpoint (#40166)
Leavrth Jan 4, 2023
be112dc
planner: skip plan-cache for prepared queries with `INT in (Decimals.…
qw4990 Jan 5, 2023
d027270
statistics: support historical stats dump partition table (#40310)
Yisaer Jan 5, 2023
37f045c
*: update badger (#40331)
xiongjiwei Jan 5, 2023
508b601
expression: enlarge timeout for test (#40332)
hawkingrei Jan 5, 2023
4a5a447
resourcemanger: add cpu scheduler (#39886)
hawkingrei Jan 5, 2023
5eea731
util: use go-deadlock to find deadlock (#40288)
hawkingrei Jan 5, 2023
affe126
*: support `curdate()` as column's default value | tidb-test=pr/2057…
CbcWestwolf Jan 5, 2023
7e64d04
ttl: don't schedule ttl job when EnableTTLJob is off (#40336)
YangKeao Jan 5, 2023
669ba5c
*: add warnings to slow log and slow query table (#39884)
time-and-fate Jan 5, 2023
331f69f
planner,infoschema,executor: Add tiflash fine grained shuffle support…
yibin87 Jan 6, 2023
e1a2b58
ddl: fill in original default for extra writable columns in batch ins…
YangKeao Jan 6, 2023
88842fa
ddltest: update goleak and enable race (#40357)
hawkingrei Jan 6, 2023
852fdc6
planner: let the planner can select IndexMerge on MVIndex without hin…
qw4990 Jan 6, 2023
3291b6d
makefile: enable deadlock in the with-real-tikv (#40359)
hawkingrei Jan 6, 2023
99100d4
planner: support more types to use IndexMerge to access MVIndex (#40343)
qw4990 Jan 6, 2023
6477d2b
log-backup: should set default value `gc.ratio-threshold` after pitr …
joccau Jan 6, 2023
b8490bc
domain: let plan replayer dump support recording stats mem status (#4…
Yisaer Jan 6, 2023
af968f2
docs: add TiDB Forum link and adjust link order (#39868)
luzizhuo Jan 6, 2023
43ebc64
ddl: support online create multi-valued index (#40304)
xiongjiwei Jan 6, 2023
b226dfc
ttl: add `ttl_job_interval` attribute and remove `tidb_ttl_job_interv…
YangKeao Jan 6, 2023
005c8d8
*: remove the support of the `amending transaction` (#39714)
wjhuang2016 Jan 6, 2023
f600fc6
executor: reset the related session vars for both INSERT and REPLACE …
winoros Jan 6, 2023
f9f7268
*: fix static pruning partition table in disaggregated tiflash mode (…
guo-shaoge Jan 6, 2023
b906bf9
planner: fix typo (#40367)
Dousir9 Jan 6, 2023
a9d8bfe
session: fix data race in the LazyTxn.LockKeys (#40350)
hawkingrei Jan 6, 2023
f7c87c8
build(deps): bump golang.org/x/crypto from 0.1.0 to 0.5.0 (#40379)
dependabot[bot] Jan 7, 2023
2d755a8
executor: fix data race at the ShowExec (#39817)
hawkingrei Jan 9, 2023
4a8006c
planner: fix panic during starting tidb-server if creating global bin…
Yisaer Jan 9, 2023
b477b1c
*: Supports create/alter/drop resource group (#40188)
nolouch Jan 9, 2023
408a466
session: fix deadlock when init domain failed (#40409)
Defined2014 Jan 9, 2023
83ec4b0
executor: support insert ignore/duplicate replace into with unique mu…
xiongjiwei Jan 9, 2023
199bb38
br: support reset_tiflash after ebs restoration (#40124)
3pointer Jan 9, 2023
7dbf1a5
ttl: add ttl goroutine exit log (#40416)
YangKeao Jan 9, 2023
0f838d9
planner, executor: split the range for unsigned pk of partition table…
winoros Jan 9, 2023
362defb
planner: add nil check when handling empty charset in `setUnionFlen` …
time-and-fate Jan 9, 2023
b912237
planner: support keep_order and no_keep_order hint (#40089)
Reminiscent Jan 9, 2023
e2a14ce
planner: unify the behavior of prepare/execute limit to mysql (#40360)
fzzf678 Jan 10, 2023
f5362f9
gpool: register gpool into resource manager (#40410)
hawkingrei Jan 10, 2023
9826913
ttl: Add `CommandClient` to trigger TTL job manually (#40346)
lcwangchao Jan 10, 2023
3f223b3
ttl: make ttl's group in granfana collapse by default (#40444)
lcwangchao Jan 10, 2023
be31b6c
br: reset cloud_admin and root after ebs restoration (#39986)
3pointer Jan 10, 2023
45d71af
ddl: support displaying sub-job reorg type in admin show ddl (#40387)
tangenta Jan 10, 2023
f771c67
planner: support use IndexMerge to access composite MVIndex (#40426)
qw4990 Jan 10, 2023
c4d8ed1
planner: add test cases for keep_order and no_keep_order hints (#40321)
Reminiscent Jan 10, 2023
3cb091b
statistics: change the upper bound of the out-of-range estimation to …
time-and-fate Jan 10, 2023
bb314af
docs: update CI build badages (#40324)
wuhuizuo Jan 10, 2023
46e67d2
planner: update the non-prep cacheable checker (#40446)
qw4990 Jan 10, 2023
02332b2
expression, planner: exclude concat_ws from aggresive folding constan…
YangKeao Jan 10, 2023
10f0093
keyspace: introduce keyspace conf and etcd path (#40269)
ystaticy Jan 10, 2023
1c8007d
ddl: skip deleting the unmatched index key on merge (#40465)
tangenta Jan 10, 2023
46d4bf0
ci: add document about some task that will be triggered manually (#40…
hawkingrei Jan 11, 2023
db53a42
errno, store: fix ErrPDServerTimeout arguments (#40468)
dveeden Jan 11, 2023
eff7462
ttl: fix the TTL job reports error when primary key contains a column…
lcwangchao Jan 11, 2023
d2d33df
planner: support using DNF to construct IndexMerge to access MVIndex …
qw4990 Jan 11, 2023
668881f
executor: add partition table testcase for historical stats (#40453)
Yisaer Jan 11, 2023
caffd8d
ttl: forbid creating/altering a table with TTL options when pk contai…
lcwangchao Jan 11, 2023
e864d83
planner: make MVIndex be compatible with the `use/force index` hint (…
qw4990 Jan 11, 2023
e3f8d98
lightning: fix codecPDClient (#40496)
AmoebaProtozoa Jan 11, 2023
2cf328b
ddl: let concurrent truncate on the same table depend on the previous…
wjhuang2016 Jan 11, 2023
2f13578
statistics: fix estimation error when ranges are too many and modify …
time-and-fate Jan 11, 2023
cefb261
executor: fix issue of KEY_COLUMN_USAGE table return wrong result abo…
crazycs520 Jan 11, 2023
7beec04
sysvar: add switch for plan replayer capture using historical stats (…
Yisaer Jan 11, 2023
defd80a
*: upgrade go1.19.5 (#40483)
hawkingrei Jan 11, 2023
f88714d
br: need init MDL variable when GetDomain (#40512)
joccau Jan 11, 2023
eb35c77
ddl: avoid commit conflicts when updating/delete from mysql.tidb_ddl_…
mjonss Jan 11, 2023
eef8438
lightning: not set pos to end if fail to `ReadUntil` (#40232)
buchuitoudegou Jan 12, 2023
fb29c80
lightning: fix risk of OOM (#40443)
buchuitoudegou Jan 12, 2023
d8ef079
ttl: retry delete when write conflict happens in txn (#40503)
lcwangchao Jan 12, 2023
22b43ff
domain: add timeout for updateStatsWorker exit process (#40434)
Yisaer Jan 12, 2023
aef752a
lightning: continue this region round and retry on next round when Ti…
lance6716 Jan 12, 2023
df019ae
parser: use identifier as user's resource group name (#40479)
BornChanger Jan 12, 2023
26dab31
ttl: support float number and store ttl_job_interval in info schema (…
YangKeao Jan 12, 2023
a917dc5
*: add more tests and fix some bugs for multi-valued index (#40518)
xiongjiwei Jan 12, 2023
fbc38f8
planner: correctly handle expression.ScalarFunction in the buildSemi…
hawkingrei Jan 12, 2023
b8e5460
*: add new global variable tidb_enable_resource_control as a switch (…
BornChanger Jan 12, 2023
8af1250
statistics: fix a calculation logic flaw in `(*Index).GetRowCount` (#…
time-and-fate Jan 12, 2023
bd7fb08
distsql: fix a bug of ranger.Range to kv.KeyRange conversion (#40204)
tiancaiamao Jan 13, 2023
9a917c8
resourcemanager, util: add resourcemanager.Unregister when closing sp…
zimulala Jan 13, 2023
b1ecabb
txn: Optimize pessimistic transaction by supporting locking with conf…
MyonKeminta Jan 13, 2023
338fd30
ddl: reimplement get flashback cluster related key ranges (#40460)
Defined2014 Jan 13, 2023
17c0d54
executor: support set resource-group-name for kv request (#40237)
glorv Jan 13, 2023
b619324
ttl: submit ttl scan task to the system table (#40422)
YangKeao Jan 13, 2023
cbe228f
hint: fix the problem that set var hint is invalid when create bindin…
elsa0520 Jan 13, 2023
5e291ec
executor: fix 'ADMIN SHOW DDL JOB QUERIES LIMIT m OFFSET n' may retur…
lyzx2001 Jan 13, 2023
73f2360
log-backup: remove k-v record in etcd when stop log-backup task (#40431)
joccau Jan 14, 2023
604883a
planner: introduce a new variable to adjust the penalty double read c…
qw4990 Jan 15, 2023
ee6d291
planner: fix prepare explain index out of range bug (#40568)
fzzf678 Jan 16, 2023
a21098f
util: support enhance waitGroupper with exited checking (#40557)
Yisaer Jan 16, 2023
03e192b
privileges: add missing items for `show privileges` | tidb-test=pr/2…
CbcWestwolf Jan 16, 2023
86f3982
tests: Add test case for the constraint check on repeated pessimistic…
MyonKeminta Jan 16, 2023
1083f79
handle: use separete ctx for initStats (#40604)
Yisaer Jan 16, 2023
7ba1f0a
resourcemanager: add task manager to support forcing to stop the task…
hawkingrei Jan 16, 2023
dbce2cb
*: update client-go (#40622)
sticnarf Jan 16, 2023
aa51b46
executor: fix concurrent use of `testkit` in tests and add nil check …
time-and-fate Jan 16, 2023
b9fb22d
statistics: fix data race in the Handle.IsTableLocked (#40572)
hawkingrei Jan 17, 2023
4620df6
executor,store/copr: trace the buildCopTask and limitExec close durat…
tiancaiamao Jan 17, 2023
17df596
planner: prepared plan cache support cached plan with placeholder in …
fzzf678 Jan 17, 2023
bdc6f4b
planner: refactor to put all plan-cacheability-check functions togeth…
qw4990 Jan 17, 2023
90e7271
testkit: reset the resource manager after test finishes (#40638)
hawkingrei Jan 17, 2023
45e85d9
planner: disable plan-cache for plans with IndexMerge accessing Multi…
qw4990 Jan 17, 2023
faffcd9
test: add more foreign key test (#40650)
crazycs520 Jan 17, 2023
a2e1e9b
ddl: Block change column on partitioned table if data needs change. (…
mjonss Jan 17, 2023
a879ba2
planner: show un-cacheable reasons for execute statements (#40651)
qw4990 Jan 17, 2023
4bb51e7
ddl: cancel `create view` job , when failed to drop old view (#40353)
zeminzhou Jan 17, 2023
f7d35ab
domain: use enhanced waitGroupWrapper in domain #40606 (#40626)
Yisaer Jan 17, 2023
22746c0
privilege,planner/core: add dynamic privilege RESOURCE_GROUP_ADMIN fo…
tiancaiamao Jan 17, 2023
971deb6
*: add a new I_S table and support show create for resource groups (#…
BornChanger Jan 17, 2023
787cb27
meta: add lock at autoid.(*allocator).Base() (#40588)
Dousir9 Jan 17, 2023
a761c02
*: Support learner replica read (#39979)
v01dstar Jan 18, 2023
05e2016
Revert "planner: show un-cacheable reasons for execute statements" (#…
qw4990 Jan 18, 2023
5cb64fd
executor: fix buildTableReaderForIndexJoin on partition table (#40674)
tiancaiamao Jan 18, 2023
1f44d20
util: remove empty folder (#40681)
hawkingrei Jan 18, 2023
6b752fe
domain: let background process unify wg.Run (#40640)
Yisaer Jan 18, 2023
89de573
BR: add lock with ttl for checkpoint backup (#40563)
Leavrth Jan 18, 2023
dc30a5b
*: LOAD DATA support load one file from s3 and other OSS (#40489)
lance6716 Jan 18, 2023
f268e29
ttl: execute scan tasks (#40564)
YangKeao Jan 18, 2023
95532bb
ddl: fix the batch check for unique index (#40672)
tangenta Jan 18, 2023
2944081
resourcemanager: avoid to get nil after task finished when to stop ta…
hawkingrei Jan 18, 2023
970ac91
planner: refactor plan cache value code (#40656)
fzzf678 Jan 18, 2023
9db9c30
telemetry: resource control telemetry (#40687)
BornChanger Jan 18, 2023
7613aa3
planner: set binary collation for mv column (#40644)
xiongjiwei Jan 18, 2023
8ec2612
ddl: add some tests for flashback cluster with ddl history (#40695)
Defined2014 Jan 18, 2023
9b64d81
pitr: move step iterate backup files into worker pool (#40577)
Leavrth Jan 19, 2023
bbd1995
ddl, lightning: support detecting duplicate keys in different batch (…
tangenta Jan 19, 2023
efbdeed
json, expression: add json unary not implementation (#40723)
YangKeao Jan 19, 2023
280b773
ddl: prevent dropping in-use resource group (#40716)
BornChanger Jan 19, 2023
de856d9
store/copr: move row hint into key range (#40105)
you06 Jan 19, 2023
556c267
server, privileges: make tidb_auth_session_token compatible with pass…
djshow832 Jan 20, 2023
38a7c62
mockstore: update pd/client and client-go to repair kvproto compatibi…
HuSharp Jan 20, 2023
c8dc908
Explain : Add new item in TiFlashScanContext to record region num inf…
hongyunyan Jan 20, 2023
5b82653
*: Setup Global Resource Controller (#40732)
nolouch Jan 20, 2023
f1647c8
tests: enable race and flaky for flashback test (#40752)
hawkingrei Jan 21, 2023
6ebbe64
br: split regions before pitr restore (#39941)
Leavrth Jan 22, 2023
1e0956d
log-backup: do not resolve locks frequently when log-backup task did …
joccau Jan 22, 2023
76153ab
lint: update config of deprecated linter (#40763)
hawkingrei Jan 28, 2023
06e2b29
lightning: check hasDupe and tableID when resolve duplicate rows (#40…
sleepymole Jan 28, 2023
465ab74
planner: skip the plan cache if non-int values are converted into int…
qw4990 Jan 28, 2023
e0ab9aa
*: Remove unused binary that was accidentally added (#40782)
v01dstar Jan 28, 2023
0220773
linter: add skywalking-eyes into bazel (#40788)
hawkingrei Jan 28, 2023
bca433f
planner: remove pickFromBucket field in LRUPlanCache (#40668)
fzzf678 Jan 28, 2023
187cafc
statistics: move statsReader out of statistics/handle (#40790)
xuyifangreeneyes Jan 28, 2023
55361cf
linter: find inappropriate key in call to context.WithValue (#40769)
hawkingrei Jan 28, 2023
fb96c13
ttl: notify tidb nodes through etcd notification (#40705)
YangKeao Jan 28, 2023
26ca040
executor: add foreign key and session variable test (#40785)
crazycs520 Jan 28, 2023
4686338
ttl: add table `mysql.ttl_job_history` to store ttl job histories (#4…
lcwangchao Jan 29, 2023
774d2eb
planner: forbid the optimizer to generate point-plan upon MVIndexes (…
qw4990 Jan 29, 2023
8b1058d
planner: refactor some code related to IndexMerge and MVIndex (#40800)
qw4990 Jan 29, 2023
90c5a87
ddl: remove useless code (#40756)
zimulala Jan 29, 2023
d22795a
ttl: use a standalone manager in TriggerScanTask test (#40816)
YangKeao Jan 29, 2023
6676ca8
ddl: split some tests into new package (#40758)
hawkingrei Jan 29, 2023
ad38dbb
resourcemanager: scheduler subtask in the pool's task (#40670)
hawkingrei Jan 29, 2023
8e96350
bazel: upgrade rules_go to prepare for Go 1.20 (#40776)
hawkingrei Jan 29, 2023
f842cd9
store/copr: add a param "limit" to region cache's `SplitRegionRanges`…
tangenta Jan 29, 2023
0bcb859
br: fix checkpoint panic when BR executes gain (#40706)
Leavrth Jan 29, 2023
fe4a81d
sessionctx: add validation for tidb_enable_plan_replayer_continues_ca…
Yisaer Jan 29, 2023
4e9b563
planner: show warnings when analyzing multi-valued indexes (#40827)
qw4990 Jan 29, 2023
744de86
ddl: move update version function to a proper place (#40817)
tangenta Jan 29, 2023
5048568
lightning: support timeout for tikv/tidb retry (#40805)
lichunzhu Jan 29, 2023
b5be9f6
ttl: support telemetry for TTL (#40806)
lcwangchao Jan 29, 2023
db435e1
ttl: auto delete old rows in `mysql.tidb_ttl_job_history` (#40808)
lcwangchao Jan 29, 2023
e11cbec
lightning: support data files with bom header (#40813)
dsdashun Jan 29, 2023
9544e26
planner: support `use / force index` for multi-valued indexes (#40820)
qw4990 Jan 30, 2023
17d70c1
lightning/parser: support STARTING BY (#40821)
lance6716 Jan 30, 2023
fd5e675
planner: add a switch control if prepare stmt with param limit can be…
fzzf678 Jan 30, 2023
97e1563
metrics: add goroutine schedule latency to grafana panel (#40836)
TonsnakeLin Jan 30, 2023
28d0325
server: support getting the MVCC of the temporary index (#40830)
wjhuang2016 Jan 30, 2023
4ed4562
planner: let optimizer trace support gcSubstitute (#40815)
Yisaer Jan 30, 2023
86b058b
planner: add more test cases for MVIndex (#40853)
qw4990 Jan 30, 2023
01f4fea
planner: supply test cases for binding from history (#40864)
fzzf678 Jan 30, 2023
11839ac
ddl: unsupport flashback cluster cross `alter table attributes` (#40862)
Defined2014 Jan 30, 2023
86a6694
bindInfo: fix datarace on bindings (#40846)
Yisaer Jan 30, 2023
91686a3
executor: add historical stats test and make it enabled (#40664)
Yisaer Jan 30, 2023
ee758bc
Variables: enhance tidb_enable_gc_tuner (#40850)
TonsnakeLin Jan 30, 2023
4fd710c
ttl: add metrics for task manager (#40819)
YangKeao Jan 31, 2023
0d47a5e
lightning: enable setting conflict max-error (#40874)
dsdashun Jan 31, 2023
c8bffd4
DDL: Skip collecting TiFlash status when TiFlash is down (#40872)
Jan 31, 2023
6a55f3e
server: Return error when no password is specified for caching_sha2_p…
dveeden Jan 31, 2023
eb53aa8
br: fix br debug encode panic (#40880)
MoCuishle28 Jan 31, 2023
05edfd4
planner: fix HashAgg cannot pushdown to tiflash_compute (#40828)
guo-shaoge Jan 31, 2023
920f019
parser: Fix for field name output in multi statements (#40736)
mjonss Jan 31, 2023
00617c9
expression, cmd: fix ColumnSubstitute and allow some cases to substit…
wjhuang2016 Jan 31, 2023
6a18630
planner: forbid using IndexFullScan on multi-valued indexes (#40907)
qw4990 Jan 31, 2023
a330ec2
Squashed and rebased all reorganize-partition PRs on master
mjonss Jan 31, 2023
7a0ca62
Merge remote-tracking branch 'pingcap/feature/reorganize-partition' i…
mjonss Jan 31, 2023
8b7fe88
Post merge fix (ddl->callback pgk)
mjonss Jan 31, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
DDL: Skip collecting TiFlash status when TiFlash is down (#40872)
close #38484
hehechen authored Jan 31, 2023

Verified

This commit was signed with the committer’s verified signature.
moodysalem Moody Salem
commit c8bffd42c244e41c4e438e3e2f2b55a9ec3d5697
8 changes: 8 additions & 0 deletions ddl/ddl_tiflash_api.go
Original file line number Diff line number Diff line change
@@ -424,6 +424,14 @@ func (d *ddl) refreshTiFlashTicker(ctx sessionctx.Context, pollTiFlashContext *T
return err
}
}

failpoint.Inject("OneTiFlashStoreDown", func() {
for storeID, store := range pollTiFlashContext.TiFlashStores {
store.Store.StateName = "Down"
pollTiFlashContext.TiFlashStores[storeID] = store
break
}
})
pollTiFlashContext.PollCounter++

// Start to process every table.
20 changes: 20 additions & 0 deletions ddl/tiflashtest/ddl_tiflash_test.go
Original file line number Diff line number Diff line change
@@ -1334,3 +1334,23 @@ func TestTiFlashAvailableAfterAddPartition(t *testing.T) {
require.NotNil(t, pi)
require.Equal(t, len(pi.Definitions), 2)
}

func TestTiFlashAvailableAfterDownOneStore(t *testing.T) {
s, teardown := createTiFlashContext(t)
defer teardown()
tk := testkit.NewTestKit(t, s.store)

tk.MustExec("use test")
tk.MustExec("drop table if exists ddltiflash")
tk.MustExec("create table ddltiflash(z int) PARTITION BY RANGE(z) (PARTITION p0 VALUES LESS THAN (10))")
require.NoError(t, failpoint.Enable("github.com/pingcap/tidb/ddl/OneTiFlashStoreDown", `return`))
require.NoError(t, failpoint.Enable("github.com/pingcap/tidb/domain/infosync/OneTiFlashStoreDown", `return`))
defer func() {
require.NoError(t, failpoint.Disable("github.com/pingcap/tidb/ddl/OneTiFlashStoreDown"))
require.NoError(t, failpoint.Disable("github.com/pingcap/tidb/domain/infosync/OneTiFlashStoreDown"))
}()

tk.MustExec("alter table ddltiflash set tiflash replica 1")
time.Sleep(ddl.PollTiFlashInterval * RoundToBeAvailable * 3)
CheckTableAvailable(s.dom, t, 1, []string{})
}
12 changes: 11 additions & 1 deletion domain/infosync/tiflash_manager.go
Original file line number Diff line number Diff line change
@@ -31,6 +31,7 @@ import (

"github.com/gorilla/mux"
"github.com/pingcap/errors"
"github.com/pingcap/failpoint"
"github.com/pingcap/tidb/ddl/placement"
"github.com/pingcap/tidb/store/helper"
"github.com/pingcap/tidb/tablecodec"
@@ -89,10 +90,19 @@ func getTiFlashPeerWithoutLagCount(tiFlashStores map[int64]helper.StoreStat, tab
for _, store := range tiFlashStores {
regionReplica := make(map[int64]int)
err := helper.CollectTiFlashStatus(store.Store.StatusAddress, tableID, &regionReplica)
failpoint.Inject("OneTiFlashStoreDown", func() {
if store.Store.StateName == "Down" {
err = errors.New("mock TiFlasah down")
}
})
if err != nil {
logutil.BgLogger().Error("Fail to get peer status from TiFlash.",
zap.Int64("tableID", tableID))
return 0, err
// Just skip down or offline or tomestone stores, because PD will migrate regions from these stores.
if store.Store.StateName == "Up" || store.Store.StateName == "Disconnected" {
return 0, err
}
continue
}
flashPeerCount += len(regionReplica)
}