ddl: never write untouched index values to temp index (#41879) #41885
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #41879
What problem does this PR solve?
Issue Number: close #41880
Problem Summary:
Previously, for untouched temp index key, TiDB writes it to the memory buffer and never commits it to TiKV(by checking if the last byte is the uncommited flag).
#40749 introduced a new temp index value encoding: for each insertion, TiDB appends the new temp index value to the end based on the old value. As a result, the "uncommitted flag" is not the last byte anymore and the key-value will be incorrectly committed to TiKV. The encoding becomes invalid.
What is changed and how it works?
Check the untouched values before writting to the temp index. Because the untouched values is only used for speeding up the index reading, and the temp index is never visible to the users, we can skip writting a untouched value to the temp index.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.