-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oomtest: add message filer for oom test to avoid flaky test #42628
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/retest |
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
/test all |
/retest |
/test all |
/retest |
1 similar comment
/retest |
/retest |
/test all |
/test |
@hawkingrei: The
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
/test all |
/retest |
1 similar comment
/retest |
@@ -223,8 +258,7 @@ func (h *oomCapture) Write(entry zapcore.Entry, fields []zapcore.Field) error { | |||
return nil | |||
} | |||
// They are just common background task and not related to the oom. | |||
if entry.Message == "SetTiFlashGroupConfig" || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is the original filter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The filter is a whitelist to filter available logs for the test. But I found that more and more logs need to be set in, and there will be conflicts between them. so I have to set the specifier filter at the test checker.
Signed-off-by: Weizhen Wang <[email protected]>
e93742b
to
c373e6c
Compare
/merge |
This pull request has been accepted and is ready to merge. Commit hash: c373e6c
|
/retest |
1 similar comment
/retest |
@hawkingrei: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: close #42629
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.