Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: normalize SQL of execute command in logs when redaction enabled #42847

Merged
merged 1 commit into from
Apr 13, 2023
Merged

server: normalize SQL of execute command in logs when redaction enabled #42847

merged 1 commit into from
Apr 13, 2023

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Apr 7, 2023 •
edited by hawkingrei
Loading

What problem does this PR solve?

Issue Number: close None

Problem Summary:

What is changed and how it works?

close https://github.com/pingcap-inc/security-sevices/issues/12

See https://github.com/pingcap-inc/security-sevices/issues/12 for more details.

Check List

Tests

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 7, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CbcWestwolf
  • hawkingrei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-linked-issue size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 7, 2023
@jackysp jackysp marked this pull request as ready for review April 7, 2023 02:21
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 7, 2023
@jackysp jackysp requested review from crazycs520 and bb7133 April 7, 2023 02:25
@bb7133 bb7133 added the skip-issue-check Indicates that a PR no need to check linked issue. label Apr 7, 2023
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 7, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 9, 2023
@hawkingrei
Copy link
Member

/check-issue-triage-complete

@hawkingrei
Copy link
Member

/check-issue-triage-complete

@hawkingrei
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 72e079c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 12, 2023
@hawkingrei
Copy link
Member

/check-issue-triage-complete

1 similar comment
@hawkingrei
Copy link
Member

/check-issue-triage-complete

@wuhuizuo
Copy link
Contributor

/run-check-issue-triage-complete

@wuhuizuo
Copy link
Contributor

/check-issue-triage-complete

@hawkingrei
Copy link
Member

/test all

@ti-chi-bot ti-chi-bot merged commit 6958fd3 into pingcap:master Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazycs520 crazycs520 crazycs520 approved these changes

@CbcWestwolf CbcWestwolf CbcWestwolf approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

@bb7133 bb7133 Awaiting requested review from bb7133

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jackysp @ti-chi-bot @hawkingrei @wuhuizuo @CbcWestwolf @crazycs520 @bb7133