Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: add wait lock time in tidb_trx #43105

Merged
merged 1 commit into from
Jun 2, 2023
Merged

*: add wait lock time in tidb_trx #43105

merged 1 commit into from
Jun 2, 2023

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Apr 17, 2023

What problem does this PR solve?

Issue Number: close #43104

Problem Summary:
See the issue for details.

What is changed and how it works?

Add lock wait time.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 17, 2023 •
edited by ti-chi-bot bot
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AndreMouche

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 17, 2023
@jackysp jackysp added the sig/transaction SIG:Transaction label Apr 17, 2023
@jackysp
Copy link
Member Author

jackysp commented Apr 17, 2023

/test all

@jackysp jackysp marked this pull request as ready for review April 17, 2023 13:25
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 17, 2023
@jackysp jackysp requested a review from MyonKeminta April 17, 2023 13:25
@hawkingrei
Copy link
Member

/test all

1 similar comment
@hawkingrei
Copy link
Member

/test all

@jackysp jackysp requested a review from cfzjywxk April 18, 2023 03:13
@hawkingrei
Copy link
Member

/retest

@jackysp jackysp requested review from AndreMouche and bb7133 April 23, 2023 08:50
AndreMouche
AndreMouche approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@AndreMouche AndreMouche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 24, 2023
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 11, 2023
@jackysp jackysp force-pushed the add_wait_lock_time branch from ea4426d to baadc11 Compare May 31, 2023 20:16
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 31, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot May 31, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 2, 2023
@jackysp
Copy link
Member Author

jackysp commented Jun 2, 2023

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AndreMouche, cfzjywxk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [AndreMouche,cfzjywxk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 2, 2023
@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 2, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 2, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-02 13:20:50.733120863 +0000 UTC m=+8837.006093646: ☑️ agreed by cfzjywxk.
  • 2023-06-02 22:10:31.912864167 +0000 UTC m=+40618.185836949: ☑️ agreed by AndreMouche.

@AndreMouche
Copy link
Contributor

/merge

1 similar comment
@jackysp
Copy link
Member Author

jackysp commented Jun 2, 2023

/merge

@ti-chi-bot ti-chi-bot bot merged commit 6605403 into pingcap:master Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfzjywxk cfzjywxk cfzjywxk approved these changes

@AndreMouche AndreMouche AndreMouche approved these changes

@MyonKeminta MyonKeminta Awaiting requested review from MyonKeminta

@bb7133 bb7133 Awaiting requested review from bb7133

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/transaction SIG:Transaction size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add wait lock time in tidb_trx
5 participants
@jackysp @ti-chi-bot @hawkingrei @AndreMouche @cfzjywxk